search

qcscine / sparrow

https://scine.ethz.ch
BSD 3-Clause "New" or "Revised" License
78 stars 15 forks source link

Clang complaints about potential C++ ABI mismatch #10

Closed awvwgk closed 2 years ago

awvwgk commented 2 years ago

Compiling sparrow with clang++ raises a warning on a potential C++ ABI mismatch on Windows platforms:

[5/164] Building CXX object src/Sparrow/CMakeFiles/Sparrow.dir/Sparrow/Implementations/Dftb/DFTBMethodWrapper.cpp.o
In file included from /home/awvwgk/projects/src/git/scine/sparrow/src/Sparrow/Sparrow/Implementations/Dftb/DFTBMethodWrapper.cpp:9:
/home/awvwgk/projects/src/git/scine/sparrow/src/Sparrow/Sparrow/Implementations/Dftb/TimeDependent/LinearResponse/TDDFTBData.h:27:1: warning: 'TDDFTBData' defined as a struct here but previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]
struct TDDFTBData : public LinearResponseData {
^
/home/awvwgk/projects/src/git/scine/sparrow/src/Sparrow/Sparrow/Implementations/Dftb/DFTBMethodWrapper.h:15:1: note: did you mean struct here?
class TDDFTBData;
^~~~~
struct
1 warning generated.
nabbelbabbel commented 2 years ago

Thanks, will be fixed in the next release.

reiher-research-group commented 2 years ago

Release 3.0.1 of Sparrow is out, so this should be fixed.