search

qcubed / qcubed

The official QCubed framework git repo
https://qcubed.eu/
57 stars 47 forks source link

Question about a possible QCubed file manager #1325

Open kukrik opened 3 years ago

kukrik commented 3 years ago

Hi, @spekary, @matthiaz and other guys!

I know that the question I have raised is not here, but unfortunately we do not have a separate forum.

So I'm going to research a bit here and ask you how you built the file uploader and also the file manager for QCubed. Have you built a module for this yourself, or have you used third-party plugins and rebuilt it for the QCubed framework? Or you have turned them into plugins.

I would like to make this a QCubed v4 plugin.

All thoughts and suggestions!

Thanks in advance!

kukrik

matthiaz commented 3 years ago

QFileAsset is pretty old code.

If I remember correctly it was already there when QCodo was released originally. Also check out QFileAssetDialog. (it does use jquery dialog, but it does so via QDialog)

The base control code does the actually uploading: https://github.com/qcubed/qcubed/blob/f5bf0bc6b938df48c2b08a53f0a0c9642fcd76a7/includes/base_controls/QFileAssetBase.class.php#L103

On Mon, 30 Nov 2020 at 13:07, Tiit Papp notifications@github.com wrote:

Hi, @spekary https://github.com/spekary, @matthiaz https://github.com/matthiaz and other guys!

I know that the question I have raised is not here, but unfortunately we do not have a separate forum.

So I'm going to research a bit here and ask you how you built the file uploader and also the file manager for QCubed. Have you built a module for this yourself, or have you used third-party plugins and rebuilt it for the QCubed framework? Or you have turned them into plugins.

I would like to make this a QCubed v4 plugin.

All thoughts and suggestions!

Thanks in advance!

kukrik

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/qcubed/qcubed/issues/1325, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA26OE6OZU4LI445IDHQZHLSSODGXANCNFSM4UHPG7FA .

kukrik commented 3 years ago

How did you do something like the uploader and file manager for yourself? On what basis? Has the same QFileAsset been redesigned or whatever?

PS. I know this thing. I'm just looking for new solutions and ideas. What is your practice so far?

matthiaz commented 3 years ago

Sorry, I'm not sure I understand the question. What problem are you trying to solve?

On Mon, 30 Nov 2020 at 13:39, Tiit Papp notifications@github.com wrote:

How did you do something like the uploader and file manager for yourself? On what basis? Has the same QFileAsset been redesigned or whatever?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/qcubed/qcubed/issues/1325#issuecomment-735761653, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA26OEZAW4KLFL7XMC4LWP3SSOG6NANCNFSM4UHPG7FA .

kukrik commented 3 years ago

I apologize in advance if I formulated the question poorly. This is a very old code. Time and technology are constantly evolving.

Perhaps the more understandable question is, are you using this QFileAsset on in newer versions of QCubed? Or are you using new solutions as well as third party plugins?

Maybe you have new ideas and suggestions in this regard that we could move on with?

matthiaz commented 3 years ago

Personally? I have been using QFileAsset more or less unmodified for several years. But you can also build your own. Obviously, I you want to make changes, do so in QFileAsset and don't touch the QFileAssetBase

I don't know if anyone ever got it to work with something like https://www.plupload.com/

On Mon, 30 Nov 2020 at 13:50, Tiit Papp notifications@github.com wrote:

I apologize in advance if I formulated the question poorly. This is a very old code. Time and technology are constantly evolving.

Perhaps the more understandable question is, are you using this QFileAsset on in newer versions of QCubed? Or are you using new solutions as well as third party plugins?

Maybe you have new ideas and suggestions in this regard that we could move on with?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/qcubed/qcubed/issues/1325#issuecomment-735766877, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA26OE63A7MQSX5XETKOM43SSOILBANCNFSM4UHPG7FA .

kukrik commented 3 years ago

Good @matthiaz, you think QCubed version 2. * existing QFileAssetBase and things like that? I meant I wanted to do both - the file uploader and the file manager for QCubed v4.

Even on QCubed v3, these things were moved to the "dead" folder. That is why I am asking you for thoughts and suggestions.

PS. If necessary, I will make them as plugins and etc...

spekary commented 3 years ago

Issues are mostly related to how browsers work. The main reason that this never moved forward was that Internet Explorer never moved forward. Now that IE is a thing of the past, perhaps a better way is possible. Although, if anyone is trying to support OperaMini, the old file upload is the only way. However, file uploads with OperaMini are not very likely, as there really are not files on the device to upload.

The old file upload relied on a multipart post. This required a Server submit, Ajax would not work. It also could not handle any kind of progress report as files were uploaded. And, files were uploaded to a temporary directory on the server.

If we can rely on certain capabilities provided in semi-modern browsers, then there are a few technologies that could be used to do these uploads using javascript, although without a webSocket link, it would involve doing periodic ajax posts to report progress. Its tricky stuff. You have to expect the unexpected, like if the upload process was interrupted, or a hacker was trying to upload a huge file to break your site.

kukrik commented 3 years ago

@spekary, thanks for the good review!

The next question is what do you think of Blueimp jQuery-File-Upload? That should be very good ?! I know @vakopian once did that, but it seemed to me that this work was a bit incomplete. I was thinking of reviewing it and finding a suitable solution that is suitable for QCubed v4.

Secondly - I have to thank you a little for making CKeditor, I adapted it to QCubed v4. It works well, here is my repo https://github.com/kukrik/ckeditor. But to do this you need to merged this section https://github.com/qcubed/application/pull/24.

Third, I've made a couple of plugins: 1) https://github.com/kukrik/select2 2) https://github.com/kukrik/bootstrap-datetimepicker 3) https://github.com/kukrik/toastr

Lastly, I've come a long way with the nestedSortable plugin, but there are a few or three more issues to resolve.

What do you think of them?

spekary commented 3 years ago

Blueimp jQuery-File-Upload, the demo does not work for me, so I can't evaluate it. Perhaps some of the other members can review your code on your plugins?