search

qcz / vscode-text-power-tools

Text Power Tools extension for VS Code
https://marketplace.visualstudio.com/items?itemName=qcz.text-power-tools
MIT License
95 stars 14 forks source link

Add Japanese localization #82

Closed wany-oh closed 6 months ago

wany-oh commented 6 months ago

I was not sure if this Pull Request was what the project needed, but I tried to work on the localization.

qcz commented 6 months ago

Thanks for the PR! It is very welcome as other localizations were requested before.

Note that there are some strings in the source code as well, for example: https://github.com/qcz/vscode-text-power-tools/blob/master/src/modules/affixCommand.ts#L66-L68

Anyway I can merge this as-is after testing & some suggestions.

wany-oh commented 6 months ago

To translate messages in .ts files, we have to use vscode-l10n. It requires updating dependencies(@types/vscode >= 1.73.0), possibly involving modifications to scripts not directly involved in the localization.

https://github.com/qcz/vscode-text-power-tools/blob/bbff8b725cdc4c341982c054860376da25fa9bcc/package.json#L2578

qcz commented 6 months ago

@wany-oh Source is prepared for localization as of fbb2e98188ff4fce1e8bff1445fe210b801508ba. Hopefully I found all texts which appear on the interface.

Strings are extracted to the following file: l10n/bundle.l10n.json.