Changes to doNd and plot_id

qdev-dk / qdev-wrappers

Other

11 stars 26 forks source link

Changes to doNd and plot_id #166

Open ThorvaldLarsen opened 5 years ago

ThorvaldLarsen commented 5 years ago

Making a few changes for the new dataset functions in qdev_wrappers.

Changes in this PR:

Save arrayparameters as blobs rather than individual points
change write_period to 1s (liveplotting refresh time)
Change save_image to take data_id as input to allow use outside doNd functions
Move save_image to plotting_tools
Make simple tranformation functions for plotting. This will be replaced by a more intuitive version in the future.
Add progressbar as implemented by Estaban in #111.

This PR requires https://github.com/QCoDeS/Qcodes/pull/1430

@WilliamHPNielsen @jenshnielsen @nataliejpg

ThorvaldLarsen commented 5 years ago

@WilliamHPNielsen I added the transformation functions here. Also removed the copy of plot_by_id.

nataliejpg commented 5 years ago

is there an example notebook with any of these things in? I think that would be really valuable in general but especially in moments like this it would make it really quick to see the functionality. Otherwise sounds really good and we are definitely very keen for the row/column average tool!

ThorvaldLarsen commented 5 years ago

@nataliejpg I have added an example notebook for plotting. There is already one for doNd which I think is still up to date - this PR only fixes some bugs in doNd not their functionality.

ThorvaldLarsen commented 5 years ago

@jenshnielsen when you get a chance, can you take a quick look at this and maybe merge it? Only thing not working is multiple arrayparameters of different size, which I believe is also not working without this update to doNd functions.

nataliejpg commented 5 years ago

i like it a lot. I would add the gluing datasets together as something desirable but also see no reason not to go ahead with this merge in the meantime.

ThorvaldLarsen commented 5 years ago

@jenshnielsen this PR has been tested quite a bit at T3. Any chance we can merge it?

jenshnielsen commented 5 years ago

@ThorvaldLarsen I pushed up the changes to unify the progessbar with the rest of qcodes. I think this is ready to merge