Remove logger - Githubissues

qdev-dk / qdev-wrappers

Other

11 stars 26 forks source link

Remove logger #167

Closed ThorvaldLarsen closed 5 years ago

ThorvaldLarsen commented 5 years ago

With logger now in main qcodes i think we should remove it from qdev_wrappers.

@Dominik-Vogel

ThorvaldLarsen commented 5 years ago

We should probably make sure everyone in lab is aware of the new logger in main qcodes before merging.

WilliamHPNielsen commented 5 years ago

@ThorvaldLarsen, rather than deleting the qdev-wrappers/logger.py, I think it's a bit more human-friendly to put in a deprecation warning saying that this file is outdated and that the qcodes one should be used instead.

ThorvaldLarsen commented 5 years ago

This is probably a much better way to do this. Would you be able to add the warnings (maybe in a new PR if easier)? Not really comfortable with the python warnings...

WilliamHPNielsen commented 5 years ago

@ThorvaldLarsen, sure thing. I'll do that now.

WilliamHPNielsen commented 5 years ago

Closing this in favour of #168