search

qdev-dk / qdev-wrappers

Other
11 stars 26 forks source link

Add support for ArrayParameter in DoNds #196

Closed Dominik-Vogel closed 4 years ago

Dominik-Vogel commented 4 years ago

This is inspired by #166

see diff here: https://github.com/qdev-dk/qdev-wrappers/compare/80516e7660355501cbd8f9545316f1a374298af0...ThorvaldLarsen:doNd_save_image

Dominik-Vogel commented 4 years ago

@ThorvaldLarsen what is this sleep about? https://github.com/ThorvaldLarsen/qdev-wrappers/blob/9df2e3359804a9dc4e9172a7de4194abb25e8080/qdev_wrappers/dataset/doNd.py#L112

Dominik-Vogel commented 4 years ago

I have looked at the test and realized, that it is not actually necessary. Maybe it was when the changes first were made. @ThorvaldLarsen https://github.com/QCoDeS/Qcodes/blob/bc0118c1ee4b5a4f54b2a56bf2dbe1adcde4b59f/qcodes/dataset/measurements.py#L869-L896

jenshnielsen commented 4 years ago

The multiparameter part is afaik still not handled within qcodes

Dominik-Vogel commented 4 years ago

True, but this we should handle in qcodes.

ThorvaldLarsen commented 4 years ago

Not sure about the sleep. Also this PR is quite old so seems very plausible that what it solved has since been fixed in qcodes.

ThorvaldLarsen commented 4 years ago

Well not this PR, but the original one I made to handle array paramters with new dataset