qdm12 / ddns-updater

Container to update DNS records periodically with WebUI for many DNS providers
https://hub.docker.com/r/qmcgaw/ddns-updater/
MIT License
1.66k stars 158 forks source link

feature: improve user interface #687

Closed fuse314 closed 3 months ago

fuse314 commented 5 months ago

replaces / closes #369

fuse314 commented 5 months ago

@qdm12 The function http.FileServerFS was introduced with go 1.22.0 Can we update the go version from 1.21 to 1.22 or are there a lot of dependencies that block the update?

fuse314 commented 3 months ago

@qdm12 do you have any reservations or requests for changes in the ui? I would love to use this in the docker image.

qdm12 commented 3 months ago

Hi @fuse314

  1. Sorry for the mega delay reviewing this!
  2. Awesome work 💯 Reviewed it and nothing to say but thank you - except a few tiny minor things I pushed on your branch
  3. I've added in 67e99fdc76d92525098bbe7d0cf795bb3b3f9b81 credits to you for reworking the UI at the bottom of the webpage, let me know if this is problematic and I'll remove it

Merging it 😉