search

qdm12 / ddns-updater

Container to update DNS records periodically with WebUI for many DNS providers
https://hub.docker.com/r/qmcgaw/ddns-updater/
MIT License
1.66k stars 157 forks source link

Bug: Self-hosted healthchecks.io does not work with additional paths #721

Closed Laptop765 closed 4 months ago

Laptop765 commented 4 months ago

TLDR: Describe your issue in a one liner here

  1. Is this urgent: No

  2. DNS provider(s) you use: N/A

  3. Program version:

    Running version latest built on 2024-05-06T11:16:06.246Z (commit 542e895)

  4. What are you using to run the container: docker-compose

  5. Extra information (optional)

Self-hosted instances of healthchecks.io may have a ping url of the form ${BASE_URL}/ping/${UUID} which doesn't work with the implementation in 937a249ffac9c7b498bcf7b90936f1228a049771. I'm working on a PR to add this functionality.

RubenHCCH commented 4 months ago

I had the same problem, I simply added the path /ping in HEALTH_HEALTHCHECKSIO_BASE_URL. Maybe documenting this is enough, and with this it is not necessary to add a new environment variable.

Laptop765 commented 4 months ago

Oh that's much simpler, I didn't think to try that 😅

Laptop765 commented 4 months ago

Appending /ping to HEALTH_HEALTHCHECKSIO_BASE_URL worked for me, too. Going to close this and my PR 🙂