qdm12 / gluetun

VPN client in a thin Docker container for multiple VPN providers, written in Go, and using OpenVPN or Wireguard, DNS over TLS, with a few proxy servers built-in.
https://hub.docker.com/r/qmcgaw/gluetun
MIT License
7.93k stars 367 forks source link

Feature request: Customizable AllowedIPs (Wireguard) #1066

Closed Hey closed 1 year ago

Hey commented 2 years ago

What's the feature 🧐

This would allow local network access with tools like https://www.procustodibus.com/blog/2021/03/wireguard-allowedips-calculator/

Extra information and references

No response

hellodword commented 1 year ago

Totally agree.

But the option FIREWALL_OUTBOUND_SUBNETS works for local network access.

qdm12 commented 1 year ago

I added that feature on image qmcgaw/gluetun:pr-1291 you can use WIREGUARD_ALLOWED_IPS=0.0.0.0/0 for example (comma separated values). See #1291 for code changes. Please let me know if it works for you.

@hellodword I think @Hey meant to VPN only to access the remote LAN (on the vpn server side), not the local (gluetun side) LAN.

hellodword commented 1 year ago

@qdm12 great!

qdm12 commented 1 year ago

Does it work? Thanks!

Hey commented 1 year ago

Sorry, I am not a Gluetun user anymore.

Covernel commented 1 year ago

Does it work? Thanks!

It works on surfshark wireguard. hope it can merge to main release. https://github.com/qdm12/gluetun/discussions/1467

goooroooX commented 1 year ago

Guys, is this feature works? WIREGUARD_ADDRESSES seems to be absent in default env variables... UPD: looks like option is NOT working. Can you please implement it? This must-have feature for cross-client communications.

qdm12 commented 1 year ago

This is merged in the latest image and will be part of future release v3.36.0. You can now use WIREGUARD_ALLOWED_IPS which defaults to 0.0.0.0/0 and ::/0 (if ipv6 supported)

@goooroooX please read next time, before spreading false and out of scope information. This issue is about WIREGUARD_ALLOWED_IPS, which was in pull request image qmcgaw/gluetun:pr-1291 for testing (if you would had read a few lines above).

WIREGUARD_ADDRESSES seems to be absent in default env variables...

WIREGUARD_ADDRESSES has been in the Dockerfile for 17 months and is well documented in the Wiki.

looks like option is NOT working. Can you please implement it?

It's working well.

This must-have feature for cross-client communications.

That doesn't make any sense

goooroooX commented 1 year ago

@qdm12, so much angry for nothing. Yeah, I meant WIREGUARD_ALLOWED_IPS, indeed. Copy-paste issue makes you so unhappy, I'm sorry.

qdm12 commented 1 year ago

so much angry for nothing.

Did you try the Docker image with the PR image tag qmcgaw/gluetun:pr-1291 and it didn't work?

goooroooX commented 1 year ago

My comment was related to the recent several comments, this one in particular: "hope it can merge to main release". It was about the main branch. So yeah, I did not test pr branch, I did test main.

qdm12 commented 1 year ago

So you understood it wasn't in the latest image / main branch, but still commented to ask for it and stating the obvious (not in the latest image). If there is an issue opened, there is no point re-asking for the same issue, that's why we have issue tracking.

I receive about 5 comments per day which I try to answer to, and this takes a lot of time. When I read such a low quality and misleading comment (UPD: looks like option is NOT working. although it was working), you also waste my time (and other's time involved on this issue) so yes it makes me angry and not for nothing.