Privado zip download timeout is too short

qdm12 / gluetun

VPN client in a thin Docker container for multiple VPN providers, written in Go, and using OpenVPN or Wireguard, DNS over TLS, with a few proxy servers built-in.

https://hub.docker.com/r/qmcgaw/gluetun

MIT License

6.71k stars 331 forks source link

Privado zip download timeout is too short #2223

Closed Drmachinegun closed 1 month ago

Drmachinegun commented 2 months ago

What's the feature 🧐

Include the option to update the VPN server list from a local .zip

Extra information and references

Im trying to update the privado server list and it times out trying to connect. i copied the output from the update command in to my browser and downloaded the same .zip it was trying to download. It would be great if i could tell the command to use this zip instead of it trying to go get it something like this i guess update-local /pathtozip/ -providers provider. thanks for you time to make this its been great

github-actions[bot] commented 2 months ago

@qdm12 is more or less the only maintainer of this project and works on it in his free time. Please:

do not ask for updates, be patient
:+1: the issue to show your support instead of commenting @qdm12 usually checks issues at least once a week, if this is a new urgent bug, revert to an older tagged container image

qdm12 commented 2 months ago

The client timeout is set to 10 seconds, how long does the download take for you?? For me it's near instantaneous. I'm rather short on time and this doesn't seem like a high priority issue, so I would ideally just fix the timeout in the code and close this issue, since I may never find the time to implement such feature.

EDIT: or we could have the http timeout configurable, eventually. But ideally not, one less thing to think about for me and the users 😄

Drmachinegun commented 1 month ago

It probably takes 10 seconds or so to timeout, I'll find out how to adjust the timer, or maybe learn how to implement the feature myself, sounds fun. thanks for taking the time to create this

qdm12 commented 1 month ago

I'll find out how to adjust the timer, or maybe learn how to implement the feature myself, sounds fun.

I would go against loading data from a zip file, since not all VPN providers give a zip file. It feels it would introduce unneeded complexity and long term support. Also, it's strange it takes > 10 seconds to download that zip file, is your internet bandwidth very slow (check on fast.com) or internet latency very high? The zip file is 600KB, it should download within 10 seconds in pretty much all cases I can think of, except if you run internet infrastructure from the 90s 🤔

Drmachinegun commented 1 month ago

Internet infrastructure and speed is fine, I got it up and working using slickvpn but it expires next month, only privado gives me problems. I'll adjust the timer when I get around to messing with it again. Thanks again for your time

qdm12 commented 1 month ago

Ok thanks for letting me know, closing this for now.

github-actions[bot] commented 1 month ago

Closed issues are NOT monitored, so commenting here is likely to be not seen. If you think this is still unresolved and have more information to bring, please create another issue.

This is an automated comment setup because @qdm12 is the sole maintainer of this project which became too popular to monitor issues closed.