search

qdot / syncydink

A web based video player that supports multiple viewing modes, haptic formats, and output devices
http://buttplug.world/syncydink
BSD 3-Clause "New" or "Revised" License
21 stars 20 forks source link

Nicely formatting the styles #57

Closed mirshko closed 6 years ago

mirshko commented 6 years ago

For sure a WIP PR

qdot commented 6 years ago

So first off, thanks for the PR! Now for the bad news.... >.>

I've been working on the 51-encydink branch, and since this has been a solo project so far, hadn't merged it for 2 months (turned out to be a pretty complicated feature). I've landed what was on that branch to master, but it's going to look way different than what you were working with. In that branch, I did a few sweeps through the styling to try and get all everything flexboxed, deal with the d3 graphs, the ButtplugPanel is now its own component in its own npm module, etc...

That said, if you don't mind possibly redoing a bit of this patch, I'd REALLY appreciate it and will definitely accept it. I was originally gonna go with LESS for this project in the first place, and then it became yet another thing to learn on top of typescript/vue, so that kinda went out the window. It'd be really nice to have your example to work from. :D

mirshko commented 6 years ago

@qdot Sounds good! Ill close this and start again from master :)