Updated to winapi 3.6.0

qdot / systray-rs

Allows rust applications to show a platform specific system tray icon and menu.

BSD 3-Clause "New" or "Revised" License

170 stars 66 forks source link

Updated to winapi 3.6.0 #31

Closed Tacklebox closed 4 years ago

Tacklebox commented 6 years ago

This should address issue #28

bbigras commented 5 years ago

Any ETA for this?

Tacklebox commented 5 years ago

@bbigras I think qdot is done with this project if i understand #25 correctly. If I get time I might fork to keep it going since I'm using it myself but I don't know yet.

qdot commented 5 years ago

@Tacklebox @bbigras Yeah I'm pretty much out on this project now, I don't have time to support it anymore. If someone wants to fork and take over, let me know. I can also turn it into an org managed repo.

qdot commented 5 years ago

BTW, if bringing in this patch will help, I can do that at least. However, I'm gonna be doing it blind, so I'll need some reassurance. :)

udoprog commented 5 years ago

I've got a branch where I've done a number of changes which helps writing applications with systray-rs: https://github.com/udoprog/systray-rs

Some of the things I did:

Moved to 2018 edition.
Incorporated all changes from this PR.
Callbacks are now FnMut -> Result<(), systray::Error> and marked them Send + Sync.
- Without FnMut, you can take mutable ownership of things from the closure's environment which really limits utility.
Renamed error type from SystrayError to Error and added a variant which takes a boxed error from the callbacks.
&String parameters to &str.
Expose set_icon_from_buffer on Windows.

qdot commented 4 years ago

@udoprog Hey! Would you be interested in PR'ing your changes to this repo? I'm back to being active in rust again and would like to get this library upgraded, and don't wanna redo work. :)

qdot commented 4 years ago

I've got go-ahead from @udoprog to bring their changes into the depo. I'll do this on the dev branch and probably close out this PR when that happens.

qdot commented 4 years ago

As of 0.4.0, I've pulled in all of @udoprog's patches, so we're on WinAPI 0.3.8 now. I did a quick check and the example compiled and seemed to basically work on windows (had some icon issues but eh), so I'm calling this good for now.