search

qdot / systray-rs

Allows rust applications to show a platform specific system tray icon and menu.
BSD 3-Clause "New" or "Revised" License
170 stars 66 forks source link

macOS support #40

Open alexandrvicente opened 4 years ago

alexandrvicente commented 4 years ago

Includes @application-developer-DA's patches and support for missing features, such as callbacks, separators and icons from files. Partially derived from https://github.com/rust-sysbar/rust-sysbar.

alexandrvicente commented 4 years ago

I did not check it in details (and did not test it as well), but apart from the things I've mentioned in comments it looks ok. Fixing the CI and/or PR to pass all checks would also be nice.

Thanks for mentioning those issues, I updated the PR fixing those and it passed all checks now.

qdot commented 4 years ago

Awesome PR! I'm a little busy this week, but I'm hoping to take a look at this and possibly get it in and roll another package version this weekend.

ancwrd1 commented 4 years ago

Hi, are there remaining blockers before this could be merged?

qdot commented 4 years ago

The pub on wait_for_message was fixed, but I believe this still panics on windows. So that's a blocker.