search

qdouble / angular-webpack-starter

A complete Angular 6 and Webpack 4 starter seed with minimal and full featured branches. Full featured branch includes: Material Design 2 (Bootstrap 4 branch available as well), @ngrx, HMR, DLLs and optional use of Universal for server-side rendering - Supports AOT (offline) compilation, sync and lazy loading. Karma/Protractor for e2e/unit tests.
MIT License
882 stars 181 forks source link

Feature: Universal Support #15

Closed mclouvem closed 8 years ago

mclouvem commented 8 years ago

Hi @qdouble,

Now with Angular 2.0.0 and Angular Universal 2.0.0 is out, is there any plan to add it to this kit?

Or could you provide some guidance how to make it?

qdouble commented 8 years ago

@mclouvem I will probably add it soon, I was just waiting for it to be stable. I will test it out today.

qdouble commented 8 years ago

@mclouvem I started the setup for it, but I hit a bump in the road for now.... Material Design 2 doesn't currently work with Universal, so that support needs to be added for me add Universal to this repo.

You can track the issue here: https://github.com/angular/material2/issues/308

mclouvem commented 8 years ago

hey @qdouble did you read that Patrick from AngularUniversal announced that AngularUniversal is now supporting Material2?

qdouble commented 8 years ago

@mclouvem yes, it's more or less a webpack hack though rather than native support. I have it running, but seems to be some issues with md-input. I'll release initial implementation of it tonight though, I already have it up and running, just making tweaks and stuff.

qdouble commented 8 years ago

@mclouvem I just added the basic setup for Universal. Currently, there is still an issue with md-input so I'm not using it in the repo right now. I still need to add support for AOT mode while using Universal and also look into using preboot and stuff like that so values that are entered before full load are saved. It's a WIP but the basic framework is there and I've tried to lay it the project in a way where I can update it and you could easily just insert your app folder to the updated seed.

mclouvem commented 8 years ago

@qdouble that's great! Thank you it was quick... I'll update my project today. Could you explain more about what's wrong with md-input?

qdouble commented 8 years ago

It causes universal to have a circular JSON error. Should work smooth once material officially supports Universal though. On Sun, Sep 18, 2016 at 2:38 AM mclouvem notifications@github.com wrote:

@qdouble https://github.com/qdouble that's great! Thank you it was quick... I'll update my project today. Could you explain more about what's wrong with md-input?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/qdouble/angular2webpack2-starter/issues/15#issuecomment-247837601, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ7seHJBwekweIFcDYOenj0Z6IKPMJStks5qrQaRgaJpZM4J_Mfk .

qdouble commented 8 years ago

@mclouvem closing this as preboot runs fine, so Universal itself is working good. I'll ping you whenever the md-input thing is sorted out.

qdouble commented 8 years ago

@mclouvem was talking with going back and forward with patrick in Slack and got him to fix the md-input bug in the latest update, so it's working fine now 😄

mclouvem commented 8 years ago

Thanks again @qdouble. You're working hard on this starter...