search

qdrant / qdrant-haystack

An integration of Qdrant ANN vector database backend with Haystack
Apache License 2.0
42 stars 11 forks source link

fix: fix passing metadata, update .gitignore #31

Closed joein closed 1 year ago

MathiasSpanhove commented 1 year ago

This doesn't solve the exception right? Since when I use metadata I still get the exact same error? Am I missing something?

joein commented 1 year ago

@MathiasSpanhove

No, **kwargs are still propagated to QdrantBase which does not have __init__ method and then passed to Object.__init__ which does not accept **kwargs.

It will be required to update qdrant-client to 1.5.3 once it is released

MathiasSpanhove commented 1 year ago

@joein Ah I missed the qdrant-client update, thank you for your quick response and solution.

joein commented 1 year ago

@MathiasSpanhove https://github.com/qdrant/qdrant-client/pull/292

kacperlukawski commented 1 year ago

I added the test to cover that case and temporarily restricted the supported qdrant-client version to <1.5.0. It will be released as a hotfix and another version will be released once qdrant-client==1.5.3 is released.