qdrant / qdrant-helm

Apache License 2.0
102 stars 50 forks source link

ArgoCD doesn't support helm k8s lookup and thus qdrant existing secret lookup fails #249

Open pschwager opened 1 month ago

pschwager commented 1 month ago

I just tried your latest changes with a ArgoCD deployment, by specifing a apiKeys via an existing secret like

apiKey:
  valueFrom:
     secretKeyRef:
       name: "secretname"
       key: "apikeyname"

This doesn't work, as ArgoCD doesn't support the helm lookup function: https://github.com/argoproj/argo-cd/issues/5202

During debugging the issue I found out, that the qdrant helm chart tries to read the existing k8s secret and creates a new secret.

I'm looking for some alternative solution to specify the api keys outside the qdrant helm chart, so that I don't have to put the secerts as cleartext into our deployment repos... any suggestion?

justbert commented 2 weeks ago

Also hitting this. I think, instead of having the the template lookup the secret and copy it to a new secret, the secret could just be mounted. It needs to reside in the same namespace anyway.