qdrant / quaterion

Blazing fast framework for fine-tuning similarity learning models
https://quaterion.qdrant.tech/
Apache License 2.0
640 stars 45 forks source link

Added CosFace Loss #198

Closed crsdvaibhav closed 1 year ago

crsdvaibhav commented 1 year ago

@monatis This is still work in progress. Just wanted to ask few questions, by sharing the code.

Thankyou for the help!

netlify[bot] commented 1 year ago

Deploy Preview for capable-unicorn-d5e336 ready!

Name Link
Latest commit 1745697dc004f3c356e691a8f13fbd2826c9ae6e
Latest deploy log https://app.netlify.com/sites/capable-unicorn-d5e336/deploys/6424007dd3369c0008fc7c7a
Deploy Preview https://deploy-preview-198--capable-unicorn-d5e336.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

crsdvaibhav commented 1 year ago

@KarahanS I have made the changes. Does this need some more changes before merge?

KarahanS commented 1 year ago

@KarahanS I have made the changes. Does this need some more changes before merge?

Thanks for the updates! I'm not one of the official contributors of this project, so let's wait for the reviews by the maintainers for merging :)

crsdvaibhav commented 1 year ago

@monatis I have added the CosFace Loss and its test. Could you please review it? I have also added an implementation of Multi Objective Loss, could you please review it?

monatis commented 1 year ago

I needed to close this. Could you please make another PR by rebasing from master and insuring that all the tests pass --because it didn't.