qdrant / vector-db-benchmark

Framework for benchmarking vector search engines
https://qdrant.tech/benchmarks/
Apache License 2.0
250 stars 68 forks source link

refactoring: Standardize format of search params in engine configs #122

Closed tellet-q closed 3 months ago

tellet-q commented 3 months ago
  1. Address: https://github.com/qdrant/vector-db-benchmark/issues/119

Make search_params consistent across all the engines. The new format is: "search_params": [ { "parallel": 1, "config": { ... } }, ... ],

  1. Fix milvus benchmark execution by upgrading milvus image version to milvusdb/milvus:v2.3.1
KShivendu commented 3 months ago

LGTM. Please confirm that you've tested all the engines once and then we can merge this.

tellet-q commented 3 months ago

@KShivendu I have tested all the engines once with laion-small-clip dataset.

joein commented 3 months ago

this pr is breaking backwards compatibility with the previous versions, isn't it?

KShivendu commented 3 months ago

We discussed and agreed that it's okay.