set ports instead of network_mode

qdrant / vector-db-benchmark

Framework for benchmarking vector search engines

https://qdrant.tech/benchmarks/

Apache License 2.0

250 stars 68 forks source link

set ports instead of network_mode #145

Closed ekorman closed 2 weeks ago

ekorman commented 2 months ago

the docker compose files which use network_mode: host currently do not work on systems such as macos where docker uses a VM, causing run.py to error. this PR explicitly sets the ports

KShivendu commented 1 month ago

Nice catch. Thanks for creating the PR.

Can you please check other engines as well and update the PR if required? :)

ekorman commented 1 month ago

Nice catch. Thanks for creating the PR.

Can you please check other engines as well and update the PR if required? :)

@KShivendu i just went through them and weaviate also needed an update. just pushed and its working for me now.

LukasWestholt commented 2 weeks ago

I really need this too!

LukasWestholt commented 2 weeks ago

Can you look on it again @KShivendu ?

KShivendu commented 2 weeks ago

I really need this too!

Merged. Thanks for asking.

Ps. You can always checkout the branch and run it anyways :)

thanks for contributing @ekorman