Static checking - Githubissues

PVS Report

Note: Line in cpp files should be decreased by 2

pvs-studio.com/en/docs/warnings/ 1 err Help: The documentation for all analyzer warnings is available here: https://pvs-studio.com/en/docs/warnings/.

[ ] kagome/cmake-build-debug/pb/node_api_proto/generated/network/protobuf/api.v1.pb.cc 1 err V009 To use free version of PVS-Studio, source code files are required to start with a special comment.
[x] kagome/core/consensus/grandpa/structs.hpp 66 err V501 There are identical sub-expressions to the left and to the right of the '==' operator: id == id
[ ] kagome/core/consensus/grandpa/structs.hpp 149 warn V730 Not all members of a class are initialized inside the compiler generated constructor. Consider inspecting: round_number.
[ ] kagome/core/consensus/grandpa/structs.hpp 207 warn V730 Not all members of a class are initialized inside the compiler generated constructor. Consider inspecting: target_number.
[ ] kagome/core/network/types/grandpa_message.hpp 34 warn V730 Not all members of a class are initialized inside the compiler generated constructor. Consider inspecting: set_id, message.
[ ] kagome/core/network/types/grandpa_message.hpp 55 warn V730 Not all members of a class are initialized inside the compiler generated constructor. Consider inspecting: round_number, voter_set_id, last_finalized.
[x] kagome/core/api/service/system/requests/peers.hpp 30 err V758 The 'peer_manager' reference becomes invalid when smart pointer returned by a function is destroyed.
[x] kagome/core/assets/assets.cpp 1 err V008 Unable to start the analysis on this file.
[x] kagome/core/application/impl/chain_spec_impl.cpp 69 err V758 The '_outcome_try_unique_name_temporary36' reference becomes invalid when temporary object returned by a function is destroyed.
[x] kagome/core/application/impl/chain_spec_impl.cpp 72 err V758 The '_outcome_try_unique_name_temporary37' reference becomes invalid when temporary object returned by a function is destroyed.
[x] kagome/core/application/impl/chain_spec_impl.cpp 236 err V758 The '_outcome_try_unique_name_temporary44' reference becomes invalid when temporary object returned by a function is destroyed.
[x] kagome/core/application/impl/chain_spec_impl.cpp 263 err V758 The '_outcome_try_unique_name_temporary48' reference becomes invalid when temporary object returned by a function is destroyed.
[x] kagome/core/application/impl/app_configuration_impl.cpp 178 warn V612 An unconditional 'return' within a loop.
[ ] kagome/core/application/impl/app_configuration_impl.cpp 805 warn V547 Expression '!addrs.empty()' is always false.
[ ] kagome/core/application/impl/app_configuration_impl.cpp 808 err V1078 An empty container is iterated. The loop will not be executed.
[ ] kagome/core/application/impl/app_configuration_impl.cpp 946 err V1078 An empty container is iterated. The loop will not be executed.
[ ] kagome/core/application/impl/app_configuration_impl.cpp 127 err V730 Not all members of a class are initialized inside the constructor. Consider inspecting: outpeers, inpeers, in_peerslight.
[x] kagome/core/clock/impl/basic_waitable_timer.cpp 14 err V1056 The predefined identifier 'func' always contains the string 'operator()' inside function body of the lambda function.
[ ] kagome/core/blockchain/impl/block_tree_impl.cpp 513 err V1053 Calling the 'getGenesisBlockHash' virtual function in the constructor may lead to unexpected result at runtime.
[ ] kagome/core/primitives/babe_configuration.hpp 28 warn V730 Not all members of a class are initialized inside the compiler generated constructor. Consider inspecting: allowed_slots.
[ ] kagome/core/consensus/babe/types/babe_block_header.hpp 22 warn V730 Not all members of a class are initialized inside the compiler generated constructor. Consider inspecting: slot_number, authority_index.
[ ] kagome/core/consensus/babe/impl/babe_lottery_impl.cpp 93 warn V1007 The value from the potentially uninitialized optional 'res' is used. Probably it is a mistake.
[ ] kagome/core/primitives/strobe.hpp 143 warn V730 Not all members of a class are initialized inside the constructor. Consider inspecting: raw_data.
[x] kagome/core/consensus/babe/impl/block_executor_impl.cpp 132 err V1030 The 'body' variable is used after it was moved. kagome/core/consensus/babe/impl/block_executor_impl.cpp 1 err V002 Some diagnostic messages may contain incorrect line number in this file.
[x] kagome/core/consensus/grandpa/impl/environment_impl.cpp 116 err V1030 The 'prevote_justification' variable is used after it was moved.
[x] kagome/core/consensus/grandpa/impl/environment_impl.cpp 117 err V1030 The 'precommit_justification' variable is used after it was moved.
[ ] kagome/core/consensus/grandpa/grandpa_context.hpp 19 err V1062 The 'Guard' class defines a custom 'new' operator. The 'delete' operator must also be defined.
[ ] kagome/core/consensus/grandpa/grandpa_context.hpp 19 err V1062 The 'Guard' class defines a custom 'new[]' operator. The 'delete[]' operator must also be defined.
[ ] kagome/core/consensus/grandpa/impl/voting_roundimpl.hpp 45 err V730 Not all members of a class are initialized inside the constructor. Consider inspecting: threshold.
[x] kagome/core/consensus/grandpa/impl/voting_round_impl.cpp 417 err V1047 Lifetime of the lambda is greater than lifetime of the local variable 'is_ready_to_end' captured by reference.
[x] kagome/core/consensus/grandpa/impl/voting_round_impl.cpp 499 warn V1007 The value from the potentially uninitialized optional 'signed_primary_proposal_opt' is used. Probably it is a mistake.
[ ] kagome/core/consensus/grandpa/impl/voting_roundimpl.cpp 844 warn V547 Expression '!finalized.has_value()' is always true.
[x] kagome/core/crypto/keccak/keccak.c 1 err V009 To use free version of PVS-Studio, source code files are required to start with a special comment.
[ ] kagome/core/crypto/secp256k1/secp256k1_provider_impl.cpp 67 warn V1037 Two or more case-branches perform the same actions. Check lines: 67, 73
[ ] kagome/core/crypto/secp256k1/secp256k1_provider_impl.cpp 64 warn V1037 Two or more case-branches perform the same actions. Check lines: 64, 70
[ ] kagome/core/host_api/impl/child_storage_extension.cpp 89 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/child_storage_extension.cpp 114 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/child_storage_extension.cpp 149 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/child_storage_extension.cpp 173 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/child_storage_extension.cpp 224 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/child_storage_extension.cpp 250 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/child_storage_extension.cpp 277 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/child_storage_extension.cpp 325 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/child_storage_extension.cpp 348 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/host_api_impl.cpp 40 err V1056 The predefined identifier 'func' always contains the string 'operator()' inside function body of the lambda function.
[ ] kagome/core/host_api/impl/host_api_impl.cpp 44 err V1056 The predefined identifier 'func' always contains the string 'operator()' inside function body of the lambda function.
[x] kagome/core/host_api/impl/host_api_impl.cpp 350 warn V524 It is odd that the body of 'ext_crypto_secp256k1_ecdsa_recover_version_2' function is fully equivalent to the body of 'ext_crypto_secp256k1_ecdsa_recover_version_1' function.
[x] kagome/core/host_api/impl/host_api_impl.cpp 363 warn V524 It is odd that the body of 'ext_crypto_secp256k1_ecdsa_recover_compressed_version_2' function is fully equivalent to the body of 'ext_crypto_secp256k1_ecdsa_recover_compressed_version_1' function.
[ ] kagome/core/host_api/impl/misc_extension.cpp 37 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[x] kagome/core/offchain/types.hpp 121 err V596 The object was created but it is not being used. The 'throw' keyword could be missing: throw runtime_error(FOO);
[x] kagome/core/offchain/types.hpp 133 err V596 The object was created but it is not being used. The 'throw' keyword could be missing: throw runtime_error(FOO);
[x] kagome/core/host_api/impl/offchain_extension.cpp 46 err V596 The object was created but it is not being used. The 'throw' keyword could be missing: throw runtime_error(FOO);
[x] kagome/core/host_api/impl/offchain_extension.cpp 48 warn V1007 The value from the potentially uninitialized optional 'worker_opt' is used. Probably it is a mistake.
[ ] kagome/core/host_api/impl/offchain_extension.cpp 61 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[x] kagome/core/host_api/impl/offchain_extension.cpp 67 err V596 The object was created but it is not being used. The 'throw' keyword could be missing: throw runtime_error(FOO);
[ ] kagome/core/host_api/impl/offchain_extension.cpp 78 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/offchain_extension.cpp 99 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/offchain_extension.cpp 107 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/offchain_extension.cpp 134 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/offchain_extension.cpp 163 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/offchain_extension.cpp 195 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/offchain_extension.cpp 227 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/offchain_extension.cpp 280 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/offchain_extension.cpp 315 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[x] kagome/core/host_api/impl/offchain_extension.cpp 325 err V596 The object was created but it is not being used. The 'throw' keyword could be missing: throw runtime_error(FOO);
[ ] kagome/core/host_api/impl/offchain_extension.cpp 340 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[x] kagome/core/host_api/impl/offchain_extension.cpp 346 err V596 The object was created but it is not being used. The 'throw' keyword could be missing: throw runtime_error(FOO);
[x] kagome/core/host_api/impl/offchain_extension.cpp 355 err V596 The object was created but it is not being used. The 'throw' keyword could be missing: throw runtime_error(FOO);
[ ] kagome/core/host_api/impl/offchain_extension.cpp 369 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/offchain_extension.cpp 385 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[x] kagome/core/host_api/impl/offchain_extension.cpp 394 err V596 The object was created but it is not being used. The 'throw' keyword could be missing: throw runtime_error(FOO);
[ ] kagome/core/host_api/impl/offchain_extension.cpp 413 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[x] kagome/core/host_api/impl/offchain_extension.cpp 419 err V596 The object was created but it is not being used. The 'throw' keyword could be missing: throw runtime_error(FOO);
[x] kagome/core/host_api/impl/offchain_extension.cpp 427 err V596 The object was created but it is not being used. The 'throw' keyword could be missing: throw runtime_error(FOO);
[ ] kagome/core/host_api/impl/offchain_extension.cpp 442 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/offchain_extension.cpp 461 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed. kagome/core/host_api/impl/offchain_extension.cpp 1 err V002 Some diagnostic messages may contain incorrect line number in this file.
[ ] kagome/core/host_api/impl/storage_extension.cpp 81 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 116 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 132 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 150 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 174 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 191 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 200 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 210 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 253 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 260 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[x] kagome/core/host_api/impl/storage_extension.cpp 269 err V758 The 'res' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 280 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 308 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 380 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 433 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/host_api/impl/storage_extension.cpp 501 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[x] kagome/core/metrics/impl/prometheus/registry_impl.hpp 105 err V503 This is a nonsensical comparison: pointer < 0.
[x] kagome/core/metrics/impl/prometheus/registry_impl.hpp 162 warn V522 There might be dereferencing of a potential null pointer.
[ ] kagome/core/runtime/executor.hpp 177 err V758 The 'memory' reference becomes invalid when temporary object returned by a function is destroyed.
[ ] kagome/core/runtime/runtime_api/parachain_host_types.hpp 150 warn V730 Not all members of a class are initialized inside the compiler generated constructor. Consider inspecting: descriptor.
[ ] kagome/core/telemetry/impl/service_impl.hpp 148 warn V730 Not all members of a class are initialized inside the compiler generated constructor. Consider inspecting: origin. kagome/core/network/impl/peer_manager_impl.cpp 1 err V002 Some diagnostic messages may contain incorrect line number in this file.
[x] kagome/core/network/adapters/protobuf_block_response.hpp 114 err V1030 The 'bodies' variable is used after it was moved.
[x] kagome/core/network/adapters/protobuf_block_response.hpp 117 err V1030 The 'justification' variable is used after it was moved.
[x] kagome/core/offchain/impl/offchain_local_storage.cpp 40 warn V779 Unreachable code detected. It is possible that an error is present.
[x] kagome/core/offchain/impl/offchain_local_storage.cpp 67 warn V779 Unreachable code detected. It is possible that an error is present.
[ ] kagome/core/offchain/impl/httprequest.cpp 24 err V730 Not all members of a class are initialized inside the constructor. Consider inspecting: secure.
[ ] kagome/core/runtime/binaryen/runtime_external_interface.cpp 571 warn V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 561, 571.
[ ] kagome/core/runtime/common/runtime_upgrade_tracker_impl.cpp 230 warn V601 The bool type is implicitly cast to the class type. Inspect the first argument.
[ ] kagome/core/runtime/wavm/memory_impl.hpp 81 err V568 It's odd that the argument of sizeof() operator is the 'array.size_bytes()' expression.
[ ] kagome/core/telemetry/impl/service_impl.cpp 36 err V730 Not all members of a class are initialized inside the constructor. Consider inspecting: lastimported.
[x] kagome/core/utils/kagome_db_editor.cpp 380 warn V519 The 'res2' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 373, 380.

cpp-check report:

Note: Find unused functions works incorrect (link). It was excluded from the report.

[ ] core/common/buffer.hpp 60:5 : Class 'Buffer' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/common/buffer.hpp 273:5 : Class 'BufferView' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/common/buffer.hpp 277:5 : Class 'BufferView' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/common/visitor.hpp 35:5 : Struct 'lambda_visitor' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/primitives/digest.hpp 174:5 : Struct 'Consensus' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/storage/trie/polkadot_trie/trie_node.hpp 25:5 : Struct 'KeyNibbles' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/storage/trie/polkadot_trie/trie_node.hpp 26:5 : Struct 'KeyNibbles' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/common/tagged.hpp 32:5 : Class 'Tagged < Empty , POL1 , std :: conditional_t < std :: is_scalar_v < Empty > , Wrapper < Empty > , Empty > >' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/common/tagged.hpp 32:5 : Class 'Tagged < Empty , BEEF , std :: conditional_t < std :: is_scalar_v < Empty > , Wrapper < Empty > , Empty > >' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/containers/objects_cache.hpp 53:5 : Struct 'ObjectsCache < std :: vector < AdditionMessageType > , ObjsCacheDefAlloc < std :: vector < AdditionMessageType > > >' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/subscription/subscriber.hpp 91:15 : The scope of the variable 'it' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:

void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0;' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0;' here
            do_something(&i);
        }
    }
}

When you see this message it is always safe to reduce the variable scope 1 level.

[ ] core/api/service/impl/api_service_impl.cpp 121:20 : Parameter 'listeners' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
[ ] core/api/service/impl/api_service_impl.cpp 145:70 : Parameter 'listener' can be declared with const
[ ] core/api/service/impl/api_service_impl.cpp 502:51 : Parameter 'session' can be declared with const
[ ] core/api/service/impl/api_service_impl.cpp 516:19 : Parameter 'session' can be declared with const
[ ] core/api/service/impl/api_service_impl.cpp 544:19 : Parameter 'session' can be declared with const
[ ] core/api/jrpc/value_converter.hpp 132:13 : Consider using std::transform algorithm instead of a raw loop.
[ ] core/api/jrpc/value_converter.hpp 198:12 : Consider using std::transform algorithm instead of a raw loop.
[x] core/api/service/base_request.hpp 115:9 : Found a exit path from function with non-void return type that has missing return statement
[ ] core/api/service/base_request.hpp 23:43 : Access of forwarded variable 'f'.
[ ] core/api/service/author/impl/author_api_impl.cpp 157:52 : Parameter 'extrinsic' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
[ ] core/api/service/author/impl/author_api_impl.cpp 144:29 : Parameter 'it' can be declared with const
[ ] core/api/service/chain/requests/get_block_hash.cpp 86:21 : Consider using std::transform algorithm instead of a raw loop.
[x] core/api/service/child_state/impl/child_state_api_impl.cpp 153:42 : Unused variable: hash_opt
[ ] core/api/service/system/impl/system_api_impl.cpp 86:21 : The scope of the variable 'nonce' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
```
void f(int x)
{
int i = 0;
if (x) {
    // it's safe to move 'int i = 0;' here
    for (int n = 0; n < 10; ++n) {
        // it is possible but not safe to move 'int i = 0;' here
        do_something(&i);
    }
}
}
```
When you see this message it is always safe to reduce the variable scope 1 level.
[ ] core/api/service/rpc/impl/rpc_api_impl.hpp 16:5 : Class 'RpcApiImpl' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/application/impl/app_configuration_impl.cpp 125:25 : Member variable 'AppConfigurationImpl::outpeers' is not initialized in the constructor.
[ ] core/application/impl/app_configuration_impl.cpp 125:25 : Member variable 'AppConfigurationImpl::inpeers' is not initialized in the constructor.
[ ] core/application/impl/app_configuration_impl.cpp 125:25 : Member variable 'AppConfigurationImpl::in_peerslight' is not initialized in the constructor.
[ ] core/application/impl/app_configuration_impl.cpp 151:19 : Parameter 'chain_id' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
[ ] core/application/impl/app_configuration_impl.cpp 155:59 : Parameter 'chain_id' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
[ ] core/application/impl/app_configuration_impl.cpp 159:59 : Parameter 'chain_id' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
[x] core/application/impl/app_configuration_impl.cpp 265:70 : Parameter 'val' can be declared with const. However it seems that 'parse_general_segment' is a callback function, if 'val' is declared with const you might also need to cast function pointer(s).
[x] core/application/impl/app_configuration_impl.cpp 275:73 : Parameter 'val' can be declared with const. However it seems that 'parse_blockchain_segment' is a callback function, if 'val' is declared with const you might also need to cast function pointer(s).
[x] core/application/impl/app_configuration_impl.cpp 281:70 : Parameter 'val' can be declared with const. However it seems that 'parse_storage_segment' is a callback function, if 'val' is declared with const you might also need to cast function pointer(s).
[x] core/application/impl/app_configuration_impl.cpp 287:70 : Parameter 'val' can be declared with const. However it seems that 'parse_network_segment' is a callback function, if 'val' is declared with const you might also need to cast function pointer(s).
[x] core/application/impl/app_configuration_impl.cpp 306:73 : Parameter 'val' can be declared with const. However it seems that 'parse_additional_segment' is a callback function, if 'val' is declared with const you might also need to cast function pointer(s).
[ ] core/application/modes/recovery_mode.hpp 18:5 : Class 'RecoveryMode' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[x] core/primitives/inherent_data.hpp 51:42 : Searching before insertion is not necessary. Instead of 'data[identifier]=common::Buffer(scale::encode(inherent).value())' consider using 'data.try_emplace(identifier, common::Buffer(scale::encode(inherent).value()));'.
[ ] core/primitives/inherent_data.hpp 100:11 : Consider using std::copy algorithm instead of a raw loop.
[x] core/blockchain/impl/block_tree_impl.cpp 976:24 : Using std::move for returning object by-value from function will affect copy elision optimization. More: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-return-move-local
[x] core/blockchain/impl/block_tree_impl.cpp 908:11 : Variable 'finish_block_hash' can be declared with const
[ ] core/blockchain/impl/block_tree_impl.cpp 1277:29 : Parameter 'p' can be declared with const
[ ] core/blockchain/impl/block_tree_impl.cpp 1228:16 : Consider using std::transform algorithm instead of a raw loop.
[ ] core/blockchain/impl/cached_tree.cpp 264:17 : Local variable 'it' shadows outer variable
[x] core/blockchain/impl/cached_tree.cpp 266:20 : Variable 'hash' is assigned a value that is never used.
[x] core/consensus/babe/impl/babe_impl.cpp 315:42 : Redundant assignment of 'announce' to itself.
[x] core/consensus/babe/impl/babe_impl.cpp 206:13 : Variable 'first_block_header' can be declared with const
[x] core/consensus/babe/impl/babe_impl.cpp 867:13 : Variable 'first_block_header' can be declared with const
[x] core/consensus/babe/impl/block_executor_impl.cpp 154:13 : Variable 'first_block_header' can be declared with const
[x] core/consensus/babe/impl/threshold_util.cpp 21:64 : Parameter 'authority' can be declared with const
[ ] core/primitives/strobe.hpp 143:5 : Member variable 'Strobe::raw_data' is not initialized in the constructor.
[ ] core/primitives/strobe.hpp 156:13 : Member variable 'Strobe::currentposition' is not assigned a value in 'Strobe::operator='.
[ ] core/primitives/strobe.hpp 156:13 : Member variable 'Strobe::beginposition' is not assigned a value in 'Strobe::operator='.
[ ] core/primitives/strobe.hpp 156:13 : Member variable 'Strobe::currentstate' is not assigned a value in 'Strobe::operator='.
[ ] core/consensus/grandpa/impl/voting_roundimpl.hpp 45:5 : Member variable 'VotingRoundImpl::threshold' is not initialized in the constructor.
[ ] core/common/tagged.hpp 32:5 : Class 'Tagged < bool , IsPreviousRoundChanged , std :: conditional_t < std :: is_scalar_v < bool > , Wrapper < bool > , bool > >' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/common/tagged.hpp 32:5 : Class 'Tagged < bool , IsPrevotesChanged , std :: conditional_t < std :: is_scalar_v < bool > , Wrapper < bool > , bool > >' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/common/tagged.hpp 32:5 : Class 'Tagged < bool , IsPrecommitsChanged , std :: conditional_t < std :: is_scalar_v < bool > , Wrapper < bool > , bool > >' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/consensus/grandpa/impl/voting_round_impl.cpp 1110:11 : The scope of the variable 'type_str' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
```
void f(int x)
{
int i = 0;
if (x) {
    // it's safe to move 'int i = 0;' here
    for (int n = 0; n < 10; ++n) {
        // it is possible but not safe to move 'int i = 0;' here
        do_something(&i);
    }
}
}
```
When you see this message it is always safe to reduce the variable scope 1 level.
[x] core/consensus/grandpa/impl/grandpa_impl.cpp 115:35 : Either the condition '!currentround' is redundant or there is possible null pointer dereference: currentround.
[x] core/consensus/grandpa/impl/grandpa_impl.cpp 373:7 : Consecutive return, break, continue, goto or throw statements are unnecessary. The second statement can never be executed, and so should be removed.
[ ] core/consensus/grandpa/impl/grandpa_impl.cpp 427:31 : Parameter 'item' can be declared with const
[ ] core/consensus/grandpa/impl/grandpa_impl.cpp 431:31 : Parameter 'item' can be declared with const
[ ] core/consensus/authority/impl/authority_manager_impl.cpp 220:31 : Local variable 'authorities' shadows outer function
[ ] core/consensus/authority/impl/authority_manager_impl.cpp 470:10 : Local variable 'authorities' shadows outer function
[ ] core/consensus/authority/impl/authority_manager_impl.cpp 262:5 : Variable 'new_root' can be declared with const
[x] core/consensus/authority/impl/authority_manager_impl.cpp 477:18 : Access of moved variable 'authorities'.
[ ] core/consensus/authority/impl/authority_manager_impl.cpp 657:76 : Consider using std::find_if algorithm instead of a raw loop.
[ ] core/crypto/blake2/blake2s.cpp 118:30 : C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected. See also: https://www.securecoding.cert.org/confluence/display/cplusplus/EXP05-CPP.+Do+not+use+C-style+casts.
[ ] core/crypto/blake2/blake2s.cpp 131:28 : C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected. See also: https://www.securecoding.cert.org/confluence/display/cplusplus/EXP05-CPP.+Do+not+use+C-style+casts.
[ ] core/crypto/blake2/blake2s.cpp 139:30 : C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected. See also: https://www.securecoding.cert.org/confluence/display/cplusplus/EXP05-CPP.+Do+not+use+C-style+casts.
[ ] core/crypto/blake2/blake2s.cpp 155:8 : C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected. See also: https://www.securecoding.cert.org/confluence/display/cplusplus/EXP05-CPP.+Do+not+use+C-style+casts.
[ ] core/crypto/blake2/blake2s.cpp 163:30 : C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected. See also: https://www.securecoding.cert.org/confluence/display/cplusplus/EXP05-CPP.+Do+not+use+C-style+casts.
[ ] core/crypto/blake2/blake2b.cpp 162:28 : C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected. See also: https://www.securecoding.cert.org/confluence/display/cplusplus/EXP05-CPP.+Do+not+use+C-style+casts.
[ ] core/crypto/blake2/blake2b.cpp 184:8 : C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected. See also: https://www.securecoding.cert.org/confluence/display/cplusplus/EXP05-CPP.+Do+not+use+C-style+casts.
[ ] core/crypto/crypto_store/key_file_storage.cpp 175:18 : The scope of the variable 'pk' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
```
void f(int x)
{
int i = 0;
if (x) {
    // it's safe to move 'int i = 0;' here
    for (int n = 0; n < 10; ++n) {
        // it is possible but not safe to move 'int i = 0;' here
        do_something(&i);
    }
}
}
```
When you see this message it is always safe to reduce the variable scope 1 level.
[ ] core/crypto/keccak/keccak.c 115:24 : C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected. See also: https://www.securecoding.cert.org/confluence/display/cplusplus/EXP05-CPP.+Do+not+use+C-style+casts.
[ ] core/crypto/keccak/keccak.c 136:24 : C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected. See also: https://www.securecoding.cert.org/confluence/display/cplusplus/EXP05-CPP.+Do+not+use+C-style+casts.
[ ] core/crypto/keccak/keccak.c 143:24 : C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected. See also: https://www.securecoding.cert.org/confluence/display/cplusplus/EXP05-CPP.+Do+not+use+C-style+casts.
[ ] core/crypto/keccak/keccak.c 233:24 : C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected. See also: https://www.securecoding.cert.org/confluence/display/cplusplus/EXP05-CPP.+Do+not+use+C-style+casts.
[x] core/host_api/impl/offchain_extension.cpp 419:11 : Variable 'nodes_as_buffers' can be declared with const
[x] core/host_api/impl/child_storage_extension.cpp 50:17 : Redundant initialization for 'func'. The initialized value is overwritten before it is read.
[ ] core/host_api/impl/child_storage_extension.cpp 122:33 : The scope of the variable 'error_message' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
```
void f(int x)
{
int i = 0;
if (x) {
    // it's safe to move 'int i = 0;' here
    for (int n = 0; n < 10; ++n) {
        // it is possible but not safe to move 'int i = 0;' here
        do_something(&i);
    }
}
}
```
When you see this message it is always safe to reduce the variable scope 1 level.
[ ] core/host_api/impl/storage_extension.hpp 158:20 : Unused private function: 'StorageExtension::loadKey'
[ ] core/host_api/impl/storage_extension.cpp 34:7 : Consecutive return, break, continue, goto or throw statements are unnecessary. The second statement can never be executed, and so should be removed.
[ ] core/host_api/impl/storage_extension.cpp 151:20 : The scope of the variable 'error_message' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
```
void f(int x)
{
int i = 0;
if (x) {
    // it's safe to move 'int i = 0;' here
    for (int n = 0; n < 10; ++n) {
        // it is possible but not safe to move 'int i = 0;' here
        do_something(&i);
    }
}
}
```
When you see this message it is always safe to reduce the variable scope 1 level.
[ ] core/host_api/impl/storage_extension.cpp 235:24 : Variable 'state_version' is assigned a value that is never used.
[ ] core/host_api/impl/storage_extension.cpp 440:24 : Variable 'state_version' is assigned a value that is never used.
[ ] core/host_api/impl/crypto_extension.hpp 213:22 : Unused private function: 'CryptoExtension::deriveSeed'
[x] core/network/impl/stream_engine.hpp 338:0 : Syntax Error: AST broken, 'if' doesn't have two operands.
[ ] core/log/configurator.hpp 18:5 : Class 'Configurator' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/metrics/impl/prometheus/registry_impl.hpp 105:14 : Returning pointer that will be invalid when returning.
[ ] core/metrics/impl/prometheus/metrics_impl.hpp 24:5 : Class 'PrometheusCounter' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/metrics/impl/prometheus/metrics_impl.hpp 36:5 : Class 'PrometheusGauge' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/metrics/impl/prometheus/metrics_impl.hpp 51:5 : Class 'PrometheusSummary' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/metrics/impl/prometheus/metrics_impl.hpp 62:5 : Class 'PrometheusHistogram' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/metrics/impl/prometheus/registry_impl.cpp 76:9 : Consider using std::transform algorithm instead of a raw loop.
[x] cmake-build-debug/pb/node_api_proto/generated/network/protobuf/api.v1.pb.h 12:0 : #error This file was generated by a newer version of protoc which is
[ ] core/network/types/block_attributes.hpp 44:15 : Class 'BlockAttributes' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/network/types/block_attributes.hpp 48:15 : Class 'BlockAttributes' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[x] core/network/impl/sync_protocol_observer_impl.cpp 54:11 : Variable 'from_hash' can be declared with const
[x] core/network/impl/sync_protocol_observer_impl.cpp 64:11 : Variable 'chain_hash' can be declared with const
[ ] core/network/impl/rating_repository_impl.hpp 22:5 : Class 'PeerRatingRepositoryImpl' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[x] core/network/impl/rating_repository_impl.cpp 43:32 : Searching before insertion is not necessary. Instead of 'ratingtable[peer_id]=0' consider using 'ratingtable.try_emplace(peer_id, 0);'.
[ ] core/runtime/common/module_repository_impl.hpp 41:5 : Struct 'SmallLruCache < Blob < 32 > , std :: shared_ptr < Module > , uint64_t >' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/runtime/common/module_repository_impl.hpp 41:5 : Struct 'SmallLruCache < Blob < 32 > , std :: shared_ptr < ModuleInstance > , uint64_t >' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/runtime/common/module_repository_impl.hpp 52:31 : Consider using std::find_if algorithm instead of a raw loop.
[ ] core/runtime/common/runtime_upgrade_tracker_impl.cpp 108:59 : Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[ ] core/runtime/binaryen/binaryen_memory_provider.hpp 24:5 : Class 'BinaryenMemoryProvider' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/runtime/binaryen/core_api_factory_impl.cpp 49:55 : The function 'getCodeAt' overrides a function in a base class but is not marked with a 'override' specifier.
[ ] core/runtime/binaryen/memory_impl.hpp 76:10 : Virtual function 'resize' is called from constructor 'MemoryImpl(wasm::ShellExternalInterface::Memory*memory,std::unique_ptr&&allocator)' at line 19. Dynamic binding is not used.
[ ] core/runtime/binaryen/memory_impl.cpp 127:16 : Local variable 'size' shadows outer function
[ ] core/runtime/binaryen/memory_impl.cpp 135:16 : Local variable 'size' shadows outer function
[ ] core/runtime/wavm/memory_impl.hpp 100:10 : Virtual function 'resize' is called from constructor 'MemoryImpl(WAVM::Runtime::Memory*memory,std::unique_ptr&&allocator)' at line 19. Dynamic binding is not used.
[ ] core/runtime/wavm/compartment_wrapper.hpp 26:5 : Class 'CompartmentWrapper' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/runtime/wavm/intrinsics/intrinsic_resolver_impl.hpp 34:5 : Class 'IntrinsicResolverImpl' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/runtime/wavm/core_api_factory_impl.cpp 70:55 : The function 'getCodeAt' overrides a function in a base class but is not marked with a 'override' specifier.
[ ] core/runtime/wavm/intrinsics/intrinsic_module.hpp 48:34 : C-style pointer casting detected. C++ offers four different kinds of casts as replacements: static_cast, const_cast, dynamic_cast and reinterpret_cast. A C-style cast could evaluate to any of those automatically, thus it is considered safer if the programmer explicitly states which kind of cast is expected. See also: https://www.securecoding.cert.org/confluence/display/cplusplus/EXP05-CPP.+Do+not+use+C-style+casts.
[ ] core/runtime/wavm/module.cpp 69:31 : Parameter 'import' can be declared with const
[ ] core/runtime/wavm/compartment_wrapper.cpp 15:5 : Struct 'CompartmentWrapperImpl' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/common/tagged.hpp 32:5 : Class 'Tagged' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[x] core/runtime/runtime_api/impl/parachain_host_types_serde.cpp 17:58 : Parameter 'val' can be declared with const
[x] core/runtime/runtime_api/impl/parachain_host_types_serde.cpp 30:64 : Parameter 'val' can be declared with const
[x] core/runtime/runtime_api/impl/parachain_host_types_serde.cpp 46:57 : Parameter 'val' can be declared with const
[x] core/runtime/runtime_api/impl/parachain_host_types_serde.cpp 61:68 : Parameter 'val' can be declared with const
[x] core/runtime/runtime_api/impl/parachain_host_types_serde.cpp 73:64 : Parameter 'val' can be declared with const
[x] core/runtime/runtime_api/impl/parachain_host_types_serde.cpp 86:65 : Parameter 'val' can be declared with const
[x] core/runtime/runtime_api/impl/parachain_host_types_serde.cpp 99:70 : Parameter 'val' can be declared with const
[x] core/runtime/runtime_api/impl/parachain_host_types_serde.cpp 110:61 : Parameter 'val' can be declared with const
[x] core/runtime/runtime_api/impl/parachain_host_types_serde.cpp 121:54 : Parameter 'val' can be declared with const
[x] core/runtime/runtime_api/impl/parachain_host_types_serde.cpp 159:56 : Parameter 'val' can be declared with const
[x] core/runtime/runtime_api/impl/parachain_host_types_serde.cpp 174:67 : Parameter 'val' can be declared with const
[x] core/runtime/runtime_api/impl/parachain_host_types_serde.cpp 185:63 : Parameter 'val' can be declared with const
[ ] core/scale/libp2p_types.cpp 27:17 : Consider using std::transform algorithm instead of a raw loop.
[x] core/telemetry/impl/service_impl.cpp 76:11 : Variable 'endpoints' can be declared with const
[x] core/telemetry/impl/message_pool.cpp 61:17 : Variable 'entry' is assigned a value that is never used.
[ ] core/transaction_pool/impl/transaction_pool_impl.cpp 97:67 : Parameter 'extrinsic' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
[x] core/transaction_pool/impl/transaction_pool_impl.cpp 210:11 : Variable 'tx' can be declared with const
[ ] core/utils/profiler.hpp 15:5 : When an object of a class is created, the constructors of all member variables are called consecutively in the order the variables are declared, even if you don't explicitly write them to the initialization list. You could avoid assigning 't_' a value by passing the value to the constructor in the initialization list.
[ ] core/utils/kagome_db_editor.cpp 418:14 : Local variable 'cursor' shadows outer variable
[ ] core/utils/kagome_db_editor.cpp 419:14 : Local variable 'res' shadows outer variable
[x] core/offchain/impl/httprequest.cpp 22:16 : Member variable 'HttpRequest::secure' is not initialized in the constructor.
[ ] core/offchain/impl/http_request.hpp 29:5 : Class 'HttpRequest' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.
[ ] core/offchain/impl/http_request.cpp 49:41 : Parameter 'meta' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
[x] core/offchain/impl/http_request.cpp 432:14 : Consider using std::transform algorithm instead of a raw loop.
[x] core/offchain/impl/offchain_worker_impl.cpp 344:5 : Consecutive return, break, continue, goto or throw statements are unnecessary. The second statement can never be executed, and so should be removed.
[x] core/offchain/impl/offchain_worker_impl.cpp 224:63 : Parameter 'meta' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
[x] core/offchain/impl/offchain_worker_impl.cpp 339:41 : Parameter 'nodes' is passed by value. It could be passed as a const reference which is usually faster and recommended in C++.
[x] core/offchain/impl/offchain_worker_impl.cpp 286:23 : Either the condition 'it==active_httprequests.end()' is redundant or there is possible dereference of an invalid iterator: it.
[x] core/offchain/impl/offchain_worker_impl.cpp 121:51 : Variable 'address' is assigned a value that is never used.

qdrvm / kagome

Static checking #1225