[codestyle] choose test asserts - Githubissues

qdrvm / kagome

Kagome - C++20 implementation of Polkadot Host

https://kagome.readthedocs.io

Apache License 2.0

160 stars 34 forks source link

[codestyle] choose test asserts #2047

Open turuslan opened 7 months ago

turuslan commented 7 months ago

Description

There are duplicate ambigous assert macro. Should choose and use one (e.g. don't use ASSERT_EQ, use EXPECT_EQ).

gtest:
```
321 EXPECT_EQ
590 ASSERT_EQ
...
```

testutil outcome (#1863):

11 ASSERT_OUTCOME_ERROR
16 EXPECT_OUTCOME_ERROR
30 EXPECT_OUTCOME_SUCCESS
136 ASSERT_OUTCOME_SUCCESS_TRY
195 ASSERT_OUTCOME_SUCCESS

Motivation

Less ambiguity, more consistency.

Are you planning to do it yourself in a pull request ?

Maybe

turuslan commented 3 months ago

EXPECT_ and ASSERT_ were intended