search

qdrvm / kagome

Kagome - C++20 implementation of Polkadot Host
https://kagome.readthedocs.io
Apache License 2.0
159 stars 34 forks source link

[Bug]: Empty blocks if not all validators validate parachains #2131

Closed kamilsa closed 1 month ago

kamilsa commented 4 months ago

Bug Summary

Error occurs when number of parachain validators is less than number of all validators

Bug Description

It is observed that when KAGOME participates in parachains consensus in Kusama it creates blocks with no parachain inherents (Candidate backed/included). The reason is that KAGOME implements Grid and cluster topologies, that distribute manifests only among parachain validators. It is not clear how Polkadot-SDK validators create blocks with parachain inherents under the same circumstances

Steps to Reproduce

0001-parachains-pvf.toml.zip

  1. unpack
  2. run zombienet-macos-arm64 spawn -p native 0001-parachains-pvf.toml
  3. observe that KAGOME validator's blocks do not have parachain inherents

Effects of the Bug

Slow down in parachains block finalization as their manifests cannot be included in time

Expected Behavior

No response

System Information

Polkadot-SDK 1.13 KAGOME – latest master

Additional Context

No response

kamilsa commented 3 months ago

telegram-cloud-photo-size-4-5883196660069283128-y

kamilsa commented 1 month ago

implemented in #2180