search

qe-team / marmot

MARMOT - the open source framework for feature extraction and machine learning, designed to estimate the quality of Machine Translation output
ISC License
21 stars 7 forks source link

merge experiment and experiment_simple #10

Closed chrishokamp closed 9 years ago

chrishokamp commented 9 years ago

Some nagging :-)

fb6efeef462bf637446ab63a72abf0108c2f6023 creates duplicate code, which is completely untested. This should go in a branch, or in a fork of this repo, which can then be merged when the code is ready -- see gitlab flow.

Also, using spaces around parameters and in comprehensions, and indenting with 2 spaces instead of 4 does not follow the pep8 style guidelines. Since the philosophy of python is 'there's only one way to do it', we should follow the style rules. There are good extensions for vim, pycharm, etc..., which check pep8 style automatically, that's what I use.

Finally, the new python print function is an actual function, not a keyword. That means that lines like this will break on python3, and we will have to fix them later.

I only mention this stuff because I want to avoid the problems that other academic open-source projects have, where the code is messy and impossible to read. Right now at the beginning it is much easier to fix than it will be later. Feel free to criticise my code as well ;-)

varvara-l commented 9 years ago

OK, I made a new branch. Life is pain...

varvara-l commented 9 years ago

done