search

qe-team / marmot

MARMOT - the open source framework for feature extraction and machine learning, designed to estimate the quality of Machine Translation output
ISC License
21 stars 7 forks source link

build_context_creators and build_feature_extractors (in experiment_utils.py) #6

Closed varvara-l closed 9 years ago

varvara-l commented 9 years ago

It looks like build_feature_extractors (https://github.com/qe-team/marmot/blob/master/marmot/experiment/experiment_utils.py#L124) does the same as build_context_creators + build_context_creator.

Is there any sense in having both functions, or they can be merged into one?

I'm just thinking of adding another object which will be built almost like context creators and feature extractors. It looks more elegant to have a function build_object for all than to create the third almost identical function.

chrishokamp commented 9 years ago

the difference is that build_context_creator lets you do it with a single object instead of a list, and context creator also handles the 'function_output' flag. I will take a look and see how the two functions could be combined.

On Fri, Jan 16, 2015 at 6:00 PM, varvara-l notifications@github.com wrote:

Assigned #6 https://github.com/qe-team/marmot/issues/6 to @chrishokamp https://github.com/chrishokamp.

— Reply to this email directly or view it on GitHub https://github.com/qe-team/marmot/issues/6#event-220227661.

varvara-l commented 9 years ago

I've done that in "simple" branch: experiment.import_utils.build_object and build_objects

varvara-l commented 9 years ago

build_context_creator and build_feature_extractors replaced with build_objects