search

qe-yast / ruby-yui-rest-client

MIT License
1 stars 5 forks source link

Add UI controls for yast2 registration #8

Closed jknphy closed 4 years ago

jknphy commented 4 years ago

Add UI controls for yast2 registration in qt/ncurses (but it is not a complete list, only until I found some point where we could not continue testing): wizard, label, richtext.

OleksandrOrlov commented 4 years ago

LGTM.

The only question: do we want to make 'integration' tests for the introduced methods, or we'll change everything to unit tests and then remove the integration tests at all?

@rwx788, @jknphy WDYT?

jknphy commented 4 years ago

LGTM.

The only question: do we want to make 'integration' tests for the introduced methods, or we'll change everything to unit tests and then remove the integration tests at all?

@rwx788, @jknphy WDYT?

Added specs for new controls, just in case we need them and to being consistent for now.

OleksandrOrlov commented 4 years ago

LGTM. I guess, we can merge this.

rwx788 commented 4 years ago

LGTM.

The only question: do we want to make 'integration' tests for the introduced methods, or we'll change everything to unit tests and then remove the integration tests at all?

@rwx788, @jknphy WDYT?

I would keep integration tests, but just make sure that those are executed after component unit tests are executed to simplify bisection in case of failures.