Rewrite and Refactor - Githubissues

qe201020335 / HRCounter

A Beat Saber custom counter that displays your heart rate in game.

MIT License

38 stars 5 forks source link

Closed qe201020335 closed 1 year ago

qe201020335 commented 1 year ago

[x] Use nullable types and make all types' nullability accurate.
[x] Make the data source strings into an enum and get rid of all the mapper functions lying around.
[x] Rename classes
- [x] HRController -> HRDataManager
- [x] BPMDownloader -> DataSourcer
[ ] Re-think how to pass things between HRManager and BPMDownloader
[x] BPM data model class shouldn't be pausing the game
[x] Use Zenject on UI
[ ] YUR socket connection thread safe
[ ] ...

qe201020335 commented 1 year ago

Re-think how to pass things between HRManager and BPMDownloader YUR socket connection thread safe

Not necessary.

Use Zenject on UI

A later day :)

qe201020335 commented 1 year ago

I refactored all the ui to use Zenject anyways #45