qemu-bsd-user / qemu-bsd-user

Other
10 stars 12 forks source link

Fixes against blitz-next #14

Closed bdragon28 closed 3 years ago

bdragon28 commented 3 years ago
bsdimp commented 3 years ago

Make sure that checkpatch.pl likes each of these commits, and we'll be good. My eyeball suggests that it will, but it's part of the pipeline.

bdragon28 commented 3 years ago

Make sure that checkpatch.pl likes each of these commits, and we'll be good. My eyeball suggests that it will, but it's part of the pipeline.

checkpatch.pl found one style error, which I fixed.

bsdimp commented 3 years ago

These all look good to me, so I'll bring them in.

bsdimp commented 3 years ago

Hmmm, spoke too soon:

../bsd-user/ppc/target_arch_signal.h:23:13: warning: redundant redeclaration of 'bsd_ppc_is_elfv1' [-Wredundant-decls]
   23 | extern bool bsd_ppc_is_elfv1(CPUPPCState *env);
      |             ^~~~~~~~~~~~~~~~
In file included from ../bsd-user/qemu.h:55,
                 from ../gdbstub.c:35:
../bsd-user/ppc/target_arch.h:8:13: note: previous declaration of 'bsd_ppc_is_elfv1' was here
    8 | extern bool bsd_ppc_is_elfv1(CPUPPCState *env);
bsdimp commented 3 years ago

likely the one in arch_signal.h can go, but I'll check in the morning.