Commit which contained typing fixes and streamlined handling of nonexistent browser introduced a bug which caused missing browser executable and missing webdriver exceptions to misleadingly show up as QWebDriverError("No browser open. Use OpenBrowser keyword to open browser first")
Another side effect was that in such situations fallback OSScreenshot was not used to get information about the execution environment.
PR contains
a fix to these cases
a test to browser.robot which checks that a missing safari webdriver (in Windows and Linux) shows up correctly
fix to a test in Open Browser in mobile emulation mode at browser.robot which was relying on the wrong exception when trying to start a nonexistent emulation mode
added info about duty typing to CONTRIBUTING.md
There are a lot of places where if get_current_browser() is None is unnecessarily checked (due to the mentioned streamlining) but these should be cleaned up in a separate PR
Commit which contained typing fixes and streamlined handling of nonexistent browser introduced a bug which caused missing browser executable and missing webdriver exceptions to misleadingly show up as
QWebDriverError("No browser open. Use OpenBrowser keyword to open browser first")Another side effect was that in such situations fallback
OSScreenshotwas not used to get information about the execution environment.PR contains
Open Browser in mobile emulation modeat browser.robot which was relying on the wrong exception when trying to start a nonexistent emulation modeduty typingto CONTRIBUTING.mdThere are a lot of places where
if get_current_browser() is Noneis unnecessarily checked (due to the mentioned streamlining) but these should be cleaned up in a separate PR