search

qentinelqi / qweb

Keyword driven automation for the web
https://github.com/qentinelqi/qweb
Apache License 2.0
39 stars 17 forks source link

Browser comparison spacing seems to be off. #2

Closed mkorpela closed 3 years ago

mkorpela commented 3 years ago

Describe the bug On the https://qentinel.com/qweb-open-source-automation-library/ page there is a visual comparison of Browser library and QWeb.

image

The spacing on the Get Text keywords seems to be wrong. Robot Framework uses 2 or more spaces as an argument separator.

So Get Text h1 == Your cart is empty should be "Get Text   h1   ==   Your cart is empty"

Snooz82 commented 3 years ago

Yes and on Qweb side

DropDown       Size Large

Is also missing a space between Size and Large.

and the Browser Select by Option has also bugs in the arguments.

Snooz82 commented 3 years ago

It seems to me that there are generally a lot of spaces wrong.

and the Browser library test would actually fail in that case.

The AssertionOperator == verifies that a value is equal with the expected value. You test object has a . at the end of the h1. If want to check if a text contains something, you could use the contains operator.

The test could also uses css selectors, that are a bit better on that test object. like:

Click    [alt="Remove item"]
tkoukkari commented 3 years ago

Hi, This comparison is not hosted in this repo, so in general this issue does not belong here. However, we did forward the message.

Formatting is probably just a copy-paste problem or something. Yes, css selectors could have been used as well.

The comparison has now been removed.