search

qewer33 / ClearClock

A simple and clean date/time plasmoid for your KDE desktop
https://store.kde.org/p/2147871
45 stars 5 forks source link

Added compatibility für plasma 6 #16

Closed Diyou closed 7 months ago

Diyou commented 8 months ago

These are minimal changes to make the widget work with plasma 6

qewer33 commented 8 months ago

Thank you for your PR! Thanks for the typo fixes as well. I don't have a Plasma 6 installation rn so I am unable to test it. Have you tested all the preferences and made sure they work? I will merge it if yes.

Diyou commented 8 months ago

It looks like it still needs some bugs fixed. The working area does not resize appropriately with the contents and the the Bold/Italic Buttons aren't changing anything or throwing any errors.

Default Settings: image

Changing every parameter will look like: image

Diyou commented 8 months ago

When opening the Config Page the FontFamily CheckBoxes are empty but changing Fonts work: image

One Issue is that the currentIndex gets initiated with a string and when changing the font I get following error:

file:///.../ClearClock/package/contents/ui/config/configAppearance.qml:75: ReferenceError: clockFontFamilyComboBox is not defined

The clock can be recentered on the working area when resizing or toggling the background as a workaround.

Diyou commented 8 months ago

Guess the only bug remaining is that the clock does not recenter itself automatically.

Diyou commented 8 months ago

Everything should work with plasma 6 now. Also you can probably close #13 with this.

xkain commented 8 months ago

Hi,

I tested (thanks for the work), it works on KDE Neon plasma 6 but there is a problem, the size of the plasmoid remains very large even if the content is very small :

Copie d'écran_20240320_110728

Diyou commented 8 months ago

Is this different from the plasma 5 behavior? You can resize the background manually after configuring by dragging the corners.

Diyou commented 8 months ago

Ah I see its stuck with this as a min size.

xkain commented 8 months ago

No, I cannot resize the background manually after configuring, the minimum size is fixed

I just checked on a Kubuntu and the behavior was identical, sorry, it wasn't really a bug, you can see it in this screenshot: Copie d'écran_20240320_151222

Otherwise, a bug perhaps on the plasma 6 version, there is no scroll bar in the control panel.

Other than that, everything works perfectly, thank you for the hard work.

qewer33 commented 8 months ago

@Diyou is this ready to merge?

Diyou commented 8 months ago

The layout issues can be addressed in a different pr as this is not plasma 6 related. You can merge this as far as I am concerned.

xkain commented 8 months ago

Scroll bar is fixed Copie d'écran_20240320_173804

Diyou commented 8 months ago

@xKain The latest commit should allow you to resize the background after setting small fonts. There might be an issue with plasma caching the main.qml in which case you'd probably need to relog first.

image

xkain commented 8 months ago

Hi,

It hasn't changed for me, the frame is still very large and cannot be smaller and follow the size of the time if it is small.

Copie d'écran_20240322_184433

qewer33 commented 7 months ago

Thanks a lot for the PR @Diyou! I reviewed and it seems to work well. I'll upload the new version to the KDE Store and give credit to you. I'm also going to make a Reddit post so you can write your username if you have a Reddit account.

Diyou commented 7 months ago

You can refer to u/DiyouDev if you want ... certainly not a requirement tho as I'm not using reddit very much.