search

qewer33 / Exquisite

Easy window layout management for KDE Plasma
GNU General Public License v3.0
195 stars 4 forks source link

[0.5 Release] Requested and Indev Features #34

Closed qewer33 closed 5 days ago

qewer33 commented 7 months ago

Related issues: https://github.com/qewer33/Exquisite/issues/11 https://github.com/qewer33/Exquisite/issues/17 https://github.com/qewer33/Exquisite/issues/29 https://github.com/qewer33/Exquisite/issues/33

imthenachoman commented 2 months ago

Is there anything I can do to get the auto close after keyboard shortcut tiling to work? Right now it will tile when I select the keyboard shortcut, but the Exquisite window stays open.

zelch commented 2 months ago

@qewer33 I do, but I'm still trying to figure out a UI problem.

The easy part is the documentation: Just replacing:

  • shortcutModifier: Optional parameter that defines the modifier that needs to be pressed in order for shortcutKey to work. Can be one of the following: Qt.ControlModifier, Qt.ShiftModifier, Qt.AltModifier, Qt.MetaModifier. If you want to assign a single key without a modifier as a shortcut to a window, leave this parameter empty.

With:

  • shortcutModifier: Optional parameter that defines the modifier or modifiers that needs to be pressed in order for shortcutKey to work. Can be one or more of the following: Qt.ControlModifier, Qt.ShiftModifier, Qt.AltModifier, Qt.MetaModifier. If you want to require multiple modifiers, separate them with |, like: qt.ControlModifier | Qt.ShiftModifier. If you want to assign a single key with out a modifier as a shortcut to a window, leave this parameter empty.

And that actually works today.

But what doesn't work is the rendering of the shortcut in the window layout.

My first try at fixing that works fine... Except that printing Ctrl+Alt+F1 really doesn't fit in the available space.

Rendering that as C+A+F1 would fit better, but would be more ambiguous, and would change the simpler case of things like Alt+F1.

Any thoughts?

qewer33 commented 1 month ago

@zelch does breaking the text into multiple lines not work? Or maybe we can make it trancunate with ellipsis and show full shortcut text in a tooltip when it's hovered

I've picked up trying to port Exquisite to Plasma 6 again but it's proving to be really difficult with the almost non-existent KWin API documentation changelog...

zelch commented 1 month ago

@qewer33 There's no good way that I can find to break it into multiple lines.

The tooltip on hovered sounds like a good plan though.

Where are you on the port to Plasma 6? Debian Experimental finally got Plasma 6, so I'm working my way through the widgets and extensions that I'm used to, and Exquisite is next on my list. :)

A-Byte-Sized commented 1 week ago

It's been a bit since the last update here; how is the Plasma 6 port going? I might take a look into it as I miss Exquisite.

qewer33 commented 1 week ago

It's been a bit since the last update here; how is the Plasma 6 port going? I might take a look into it as I miss Exquisite.

Yeah uhh I have kinda been stuck... I got it to run without any errors on Plasma 6 but I couldn't get the Exquisite dialog to show no matter what I tried. I will push my changes to a new branch soon. Would appreciate any help!

A-Byte-Sized commented 6 days ago

Sounds good, let me know whenever you've pushed a branch and I'll take a whack at it!

zelch commented 6 days ago

I would also love to take a crack at the problem, since it sounds like you're in a decent place progress wise! :)

qewer33 commented 5 days ago

@A-Byte-Sized and @zelch I have pushed my changes to the plasma6 branch. We can use the Plasma 6 issue as a tracker, you can comment about your findings there (also please comment if you get any unexpected errors on the current commit). Thank you guys for your interest!

https://github.com/qewer33/Exquisite/tree/plasma6

qewer33 commented 5 days ago

Also seems like this issue can be closed.