Add z poly z - Githubissues

qfall / math

Library providing mathematical basics in Rust. The library is based on FLINT.

Mozilla Public License 2.0

20 stars 2 forks source link

Add z poly z #410

Closed 3pmile closed 3 weeks ago

3pmile commented 2 months ago

Description

Addition for Z and PolyOverZ

This PR implements...

[x] Z + PolyOverZ (and all burrowed versions)
[x] PolyOverZ + Z (and all burrowed versions)

for/ of Component.

Addition

Testing

[x] I added basic working examples (possibly in doc-comment)
[x] I added tests for large (pointer representation) values
[x] I triggered all possible errors in my test in every possible way
[x] I included tests for all reasonable edge cases

Checklist:

[x] I have performed a self-review of my own code
- [x] The code provides good readability and maintainability s.t. it fulfills best practices like talking code, modularity, ...
- [x] The chosen implementation is not more complex than it has to be
- [x] My code should work as intended and no side effects occur (e.g. memory leaks)
- [x] The doc comments fit our style guide
- [x] I have credited related sources if needed

3pmile commented 2 months ago

Please have a look at the implementation and whether edge cases for tests are missing