Open qfjp opened 1 year ago
Unifying items in metadata and the like has been partially accomplished:
mediainfo_<typ>
functions have become mediainfo(..., typ: StreamIndex)
. That is, they actually take the type as the parameter instead of hardcoding it into the name of the function.generate_conversions(...typ: StreamType)
in commit 60f1c09
The code is horrible and ad-hoc. The first step to fixing this is to unify the four
mediainfo
functions while adding Enumerations for everything possible within a video file's JSON.mediainfo_<typ>
functions now are one function takingtyp
as a parameter:mediainfo(fpath: PosixPath, typ: StreamType)
StreamType
enumerated object as a parameter (validate_conversions(..., typ: StreamType, ...)
,get_stream_ix_offset(...,typ: StreamType)
,generate_conversions(...,typ: StreamType,...)
compare_json_key
andcompare_json_diff
). The function should know how to handle it based on the stream property's properties. Fixed in commit 67d8dde