qfo / benchmark-webservice

This repository contains the codebase that runs the webservice to benchmark orthology predictions on a common reference proteome dataset.
http://orthology.benchmark-service.org
Other
7 stars 8 forks source link

Accumulated fixes and minor changes from BSC #4

Closed jmfernandez closed 2 years ago

jmfernandez commented 2 years ago

Since past December 2021 @lcodo , @txellferret and I have been accumulating fixes and minor changes related to the QfO benchmarking workflow, mainly related to the reproducibility. These changes can be described as:

alpae commented 2 years ago

Hi @jmfernandez ,

thanks for the PR. I've merged it, but I realized that several changes were reverted by you. I don't think that the current version is what you run at OpenEBench - the VGNC benchmark for example wouldn't run like this (it is missing the sqlite database).

Do you have some additional changes lying around? Otherwise, I will have to go through the code and add back some of the missing features.

Cheers Adrian

jmfernandez commented 2 years ago

Hi @alpae , I / we have no additional changes right now. Sorry for the unintended changes related to the VGNC benchmark . I have just checked both QfO_2020 VRE tools metadata:

Although a bit off topic, the example for the efforts to have a reproducible command line test uses https://github.com/jmfernandez/benchmark-webservice/tree/4da3128a1ab3901b6eddcaf14599b23b9700f909 , and it also has to generate a "reasonable" input file which is not discarded due the datasets (see scripts at https://github.com/inab/vre-process_nextflow-executor/tree/master/tests/QfO)