search

qfpl / applied-fp-course

Applied Functional Programming Course - Move from exercises to a working app!
http://qfpl.io/projects/professional-fp-courses/
Other
624 stars 181 forks source link

Remove the need to explain lawless (and weird) typeclass usage from tests #64

Closed mankyKitty closed 5 years ago

mankyKitty commented 5 years ago

WIP pull request for #19

Using the functions from wai-extra, build an easier to use/understand testing setup for the initial levels. This isn't as awesome as using a nicer and more purpose built testing framework. But it will work for now, there isn't any "/magic/" lying around.

Suggestions appreciated.

mankyKitty commented 5 years ago

Do you mean in the test cases for a given level or just across the board?

The tests for each level are meant to be stand alone, barring the test runner itself. I'm not against changing this structure to have a single overall test suite for the entire course but that'll take a bit more thinking. :+1:

gwils commented 5 years ago

I just mean that flushTopic is defined a number of times rather than in one common case. It's not exactly related to this PR. We could tackle it later.

mankyKitty commented 5 years ago

Not this PR but it's a good point, I've opened an issue so we don't forget. :+1: