qfpl / applied-fp-course

Applied Functional Programming Course - Move from exercises to a working app!
http://qfpl.io/projects/professional-fp-courses/
Other
624 stars 181 forks source link

the bonnet is up and we're on bricks. Fix it. #71

Closed mankyKitty closed 5 years ago

mankyKitty commented 5 years ago

This is a fixathon, hacking is for the students. :smiley:

TODO

gwils commented 5 years ago

I like the change to waargonaut. It will certainly help to get more eyes on it. It will also be the library we're best able to help with after students finish the applied course when they start their own projects.

My only concern is that it's still new, but we're happily using it in other qfpl projects, so it's proven itself.

mankyKitty commented 5 years ago

Part of the concern that was raised about using waargonaut over aeson is that the moment you leave the course, you're going to encounter an ecosystem of packages that (almost) all use aeson.

It's a question of how well this choice aligns with the purpose of the course. Does it benefit the students or are we just using the course to push our own libraries. That's an extreme wording, but it gets the point across.

Ideally, the students will gain sufficiently general Haskell skills that they can establish how things work and use the tools they want. So our choice of aeson/waargonaut shouldn't be an issue.

My anec-data thus far is that the students enjoy these sorts of discussions and discussing pros and cons of approaches is something they want to get out of the course. So I plan to keep waargonaut in there for now, but explicitly raise it with the next class to get their opinion.

gwils commented 5 years ago

When I try to build this, I get errors about Level03/Core and Level03/Types listed in the exposed-modules section of the cabal file.

mankyKitty commented 5 years ago

Hrmm, that should be fixed already.

gwils commented 5 years ago

Ah yes, the trick is to git pull.

gwils commented 5 years ago

My anec-data thus far is that the students enjoy these sorts of discussions and discussing pros and cons of approaches is something they want to get out of the course. So I plan to keep waargonaut in there for now, but explicitly raise it with the next class to get their opinion.

As you say, feedback from students would be a good way to decide this.