qgallouedec / panda-gym

Set of robotic environments based on PyBullet physics engine and gymnasium.
MIT License
506 stars 109 forks source link

Multiple panda robot #23

Closed meinczingerm closed 9 months ago

meinczingerm commented 2 years ago

This PR contains changes necessary to add and control multiple Panda robots in the same env. I added a separate example.py where there is an example of how to add multiple robots and an example env+task to test the double panda arms. The example.py is only added for easy testing, but shouldn't be merged. It might make sense to add DoublePandaArm example into documentation, or somewhere else?

meinczingerm commented 2 years ago

IMO the checks are only failing because of the example.py that should be removed anyway.

qgallouedec commented 2 years ago

Can you check the "Allow edits from maintainers" box?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

meinczingerm commented 2 years ago

It is turned on. image

codecov[bot] commented 2 years ago

Codecov Report

Merging #23 (5fb4692) into master (76cc82e) will decrease coverage by 4.43%. The diff coverage is 3.77%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   97.85%   93.42%   -4.44%     
==========================================
  Files          24       25       +1     
  Lines        1074     1125      +51     
==========================================
  Hits         1051     1051              
- Misses         23       74      +51     
Impacted Files Coverage Δ
example.py 0.00% <0.00%> (ø)
panda_gym/envs/robots/panda.py 100.00% <ø> (ø)
panda_gym/envs/core.py 97.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76cc82e...5fb4692. Read the comment docs.

qgallouedec commented 2 years ago

Any update?

meinczingerm commented 2 years ago

It seems, that this is only a conflict because of the coverage. The example.py could be removed if you don't want to have something similar somewhere.

qgallouedec commented 2 years ago

I made some comments on your changes, about typos and such, can you take a look?

meinczingerm commented 2 years ago

I didn't notice. Yest I will look at it.

mechtach714 commented 1 year ago

Good day,

Did you guys manage to get a second Franka added to the simulation? I'm trying to simulate object handover between two Franka arms and it would be wonderful if it would be a simple fix to include a second arm.