qgallouedec / panda-gym

Set of robotic environments based on PyBullet physics engine and gymnasium.
MIT License
506 stars 109 forks source link

Fixing np_random att visibility in core.Task class #40

Closed drmateo closed 1 month ago

qgallouedec commented 1 year ago

Hi, can you elaborate about the need behind that PR?

drmateo commented 1 year ago

Sure! This patch is more a style problem that must be resolved as I purpose. The two main reasons are:

qgallouedec commented 1 year ago

Sounds fair. However, I would rather go for a set_np_random(np_random) instead of the set_random_seed(seed). By the way, this method shouldn't be protected, as it its intended to be called outside the class.