Closed Xpirix closed 7 months ago
Attention: 39 lines
in your changes are missing coverage. Please review.
Comparison is base (
2057611
) 37.76% compared to head (c1c706b
) 34.57%.
Files | Patch % | Lines |
---|---|---|
qgis-app/plugins/tests/test_rename_plugin.py | 31.37% | 35 Missing :warning: |
qgis-app/plugins/views.py | 0.00% | 4 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @Xpirix , can you add unit tests please?
thanks, Hard for me to understand the PR, but in case we can have new name set and upload new version of the plugin that will not override this new name I am fine :)
That's right. The new name will not change until the admin allows to read it from metadata.txt
(Not allowed by default). So, the name value in the metadata.txt
should be updated according to the new name.
Hi @dimasciput , Thank you for reminding me. I've added unit testing for the plugin's rename feature.
That's right. The new name will not change until the admin allows to read it from
metadata.txt
(Not allowed by default). So, the name value in themetadata.txt
should be updated according to the new name.
So for me as plugin admin, what steps I need to do to update plugin visible name? I am bit confused
So for me as plugin admin, what steps I need to do to update plugin visible name? I am bit confused
Apologies for omitting the details in my previous message. Please refer to the screenshot and steps below for guidance on renaming a plugin via the administration page:
When an admin/owner uploads a new version with a name that doesn't match the existing one, an error will be triggered. To override this restriction, administrators can enable the "Allow Update Name" option by checking the corresponding checkbox as mentionned here.
When an admin/owner uploads a new version with a name that doesn't match the existing one, an error will be triggered.
This is what I do not understand: as a plugin developer, I thought name
entry in metadata.txt
should stay as the old plugin name, right? see https://docs.qgis.org/3.28/en/docs/pyqgis_developer_cookbook/plugins/plugins.html#metadata-txt
I thought that as plugin developer
name
) I assume "Allow Update Name" = ON
is how the stuff behaves before this PR , right?
You are absolutely right. Thanks for the feedbak.
I just fixed that. There is no more error when you upload a plugin zip with the old name that is different form the new name. These processes are correct:
as plugin developer
- I ask super-admin to change plugin name for me in the administrator page
- I can still upload my plugin zip via interface without any modification (== with old name)
- And my plugin will show the "new" name in QGIS install + web interface
👏
Great, let me know when this is released, so we can fix the name of Mergin plugin. Thanks!
@PeterPetrik Sure, we will let you know when this is released.
Dear @PeterPetrik, these changes are now released on the plugin website.
Very good, thanks
My pleasure.
270
271
Please find in here the details for this PR