search

qgis / QGIS-Django

Django project for QGIS related activities such as plugin repository
http://qgis.org
GNU General Public License v2.0
86 stars 59 forks source link

Fix license requirement #311

Closed Xpirix closed 7 months ago

Xpirix commented 7 months ago

Please find below the issue related to the current PR:

Guts commented 7 months ago

@Xpirix sorry bu can you give more details about what this PR does?

Xpirix commented 7 months ago

Dear @Guts ,

Many thanks for your feedback.

In this PR, The license file is only required for new plugins. For existing plugin updates, it generates just a warning (but doesn't fail) when the license file is missing. However, I'm not sure if we should also just generate a warning for new plugin uploads for now. If so, I will also fix the new plugin upload.

Kind regards.

Guts commented 7 months ago

Thanks @Xpirix for the details here.

However, I'm not sure if we should also just generate a warning for new plugin uploads for now. If so, I will also fix the new plugin upload.

Again, my "debate" is not about forcing my opinion but to discuss before deploying breaking changes. Without discussion, how is possible to apply this, straightforward to the production platform? I can't find a good answer, so I think it's preferable to only display a warning for a time, communicate to the end-users (here plugins developer) through dev list and documentation and then push the change.

And again, your work here, on this project, is such a great thing! I'm not questioning the technical work but the necessary collaborative mood of the project.