Fix errors in GH action coverage test

qgis / QGIS-Django

Django project for QGIS related activities such as plugin repository

http://qgis.org

GNU General Public License v2.0

86 stars 59 forks source link

Fix errors in GH action coverage test #323

Closed Xpirix closed 7 months ago

Xpirix commented 7 months ago

This PR is addressing the issue #322

Summary of this PR:

Update some packages (django-taggit, 'Whoosh', 'picke5') in requirements to fix errors when running tests or commands in a development environment
Update docker-compose to fix the make error in a development environment
Fix test_plugin_list and test_plugin_version_feedback to reflect the code. In test_plugin_version_feedback, <div class="span8 new-feedback"> becomes <div class="new-feedback"> because <div class="span8 new-feedback"> doesn't exist and the test will always fail.

Akiyamka commented 7 months ago

I ran this code after the fixes and it works fine now. Tested scripts:

$ make build
$ make web
$ make devweb
$ make migrate
$ make devweb-runserver
$ pip install -r REQUIREMENTS-dev.txt
$ pre-commit install --config .pre-commit-config.yaml

http://0.0.0.0:62202/admin/login/?next=/admin/ shows login screen.

However, when I open root http://0.0.0.0:62202/, I see error page

DoesNotExist at /
Menu matching query does not exist.
Error during template rendering
{% get_namedmenu Navigation as menu %}

is this expected behaviour?

Xpirix commented 7 months ago

I think it's normal when DB is empty. Running make dbseed will probably fix this.

Xpirix commented 7 months ago

@dqunbp . Thanks for the feedback. Yes, I also think it's better to specify the commit or the version to prevent errors in the future. I've just made these fixes.