qgis / QGIS-Django

Django project for QGIS related activities such as plugin repository
http://qgis.org
GNU General Public License v2.0
86 stars 59 forks source link

Add Layer Definition File and 3D Model to the resource API #388

Closed Xpirix closed 1 week ago

Xpirix commented 2 months ago

This is a proposed change for #280

Changes summary

image

ismailsunni commented 2 months ago

So, Wafefront is the 3D model? May I know why is it called like that? Otherwise, it looks good for me

Xpirix commented 2 months ago

I think it refers to the pip package the app used to manage 3D models which is called PyWavefront. It's related to #182.

ismailsunni commented 2 months ago

@Xpirix perhaps, it's better to have different terminology for the resource type since it's not self explanatory. It is also more on the technical term, not the context. See similar comment regarding this https://github.com/qgis/QGIS-Django/pull/202#issuecomment-947421398. I guess 3DModel is clearer.

Xpirix commented 2 months ago

Yes, that makes more sense. I've changed Wavefront to 3DModel for the resource API for now. Also, I will create an issue to replace all Wavefront occurrences in the code with 3DModel.

image

ismailsunni commented 2 months ago

Thanks @Xpirix !

ismailsunni commented 1 week ago

thanks lord @dimasciput