qgis / QGIS-Hub-Plugin

A QGIS plugins to fetch resources from the QGIS Hub
https://qgis.github.io/QGIS-Hub-Plugin/
GNU General Public License v3.0
4 stars 2 forks source link

Store the Response from the API as a File / Added reload button #22

Closed ronitjadhav closed 1 year ago

ronitjadhav commented 1 year ago

12

ismailsunni commented 1 year ago

I think you haven't added the part where the browser will load from the file. Or did I miss something?

Could you also put a screenshot of the new UI/dialog, when you made UI changes? I usually use Flameshot to take a screenshot (or any tool is fine)

ronitjadhav commented 1 year ago

I think you haven't added the part where the browser will load from the file. Or did I miss something?

Could you also put a screenshot of the new UI/dialog, when you made UI changes? I usually use Flameshot to take a screenshot (or any tool is fine)

  1. The logic for the browser to load from the file is in the file api_client.py on line no: 17, 18, 19
  2. Below is the screenshot of the new UI

image

ismailsunni commented 1 year ago

@ronitjadhav could you also update the button? Put a label under the Resource Type and the button next to it. To make them look tidy. I think it's good to have a tool button instead a push button. You can use reload icon that is included on QGIS.

ronitjadhav commented 1 year ago

@ismailsunni I have made changes mentioned by you:

  1. Removed reload_resources() function, merged the function with populate_resources.
  2. Updated the alignment of reload resources
  3. Replaced push button with tool button and added an icon

image