search

qgis / QGIS-Mac-Packager

Scripts for Official QGIS MacOS Packages
https://www.qgis.org
GNU General Public License v2.0
54 stars 21 forks source link

Include HANA plugin #107

Closed mrylov closed 3 years ago

mrylov commented 3 years ago

The HANA plugin has been recently merged into master. This change includes the new plugin in the QGIS-Mac-Packager.

PeterPetrik commented 3 years ago

thanks, does it need any qgis bulid flags or extra deps?

mrylov commented 3 years ago

It only needs WITH_HANA flag in QGIS build (see https://github.com/qgis/QGIS/blob/master/CMakeLists.txt). The plugin requires ODBC headers and odbc-cpp-wrapper library where the last is a part of QGIS/external folder (see https://github.com/qgis/QGIS/pull/40982).

PeterPetrik commented 3 years ago

in that case you need to add it here too https://github.com/qgis/QGIS-Mac-Packager/blob/610b41dcd8929a14ed6344399d9662955aaef35b/qgis_build/qgis_build.bash#L60

and for odbc we have this https://github.com/qgis/QGIS-Mac-Packager/blob/master/qgis_deps/recipes/unixodbc/recipe.sh hope if suits?

PeterPetrik commented 3 years ago

qgis_deps-> deps qgis_build->building qgis qgis_bundle -> creating QGIS.app

mrylov commented 3 years ago

Thank you @PeterPetrik. The unixodbc library contains headers that we need.

PeterPetrik commented 3 years ago

are you macos user?

mrylov commented 3 years ago

No, I am not.

mrylov commented 3 years ago

I've made the necessary changes in qgis_build/qgis_build.bash. Did I miss something?

PeterPetrik commented 3 years ago

no problem, I will include it later this week when doing new packages