Fix codesign --timestamp parameter

qgis / QGIS-Mac-Packager

Scripts for Official QGIS MacOS Packages

https://www.qgis.org

GNU General Public License v2.0

54 stars 21 forks source link

Fix codesign --timestamp parameter #126

Closed agiudiceandrea closed 3 years ago

agiudiceandrea commented 3 years ago

This should fix the failing builds

[34;01mSigning the QGIS.app[39;49;00m
–timestamp=none: No such file or directory
FAIL

joaoponceleao commented 3 years ago

The error is now codesign: invalid option -- â

The script seems to have one or more em-dashes instead of two dashes in lines 49 and 60:

https://github.com/qgis/QGIS-Mac-Packager/blob/cea9c7747075c9bce751f453a35fbab2b0a5ae79/qgis_package/qgis_package.bash#L60

agiudiceandrea commented 3 years ago

Thanks @joaoponceleao I didn't notice it before... It seems that now both pr and ltr dmg package are generated, but the logs/deps/pngs/sha256 are not created...

PeterPetrik commented 3 years ago

working on that this week, hopefully I can fix it till friday

joaoponceleao commented 3 years ago

but the logs/deps/pngs/sha256 are not created...

No problem. It was tricky to notice that dash. Without the logs I have no idea what's going on though - got no build system in place here.