search

qgis / QGIS-Mac-Packager

Scripts for Official QGIS MacOS Packages
https://www.qgis.org
GNU General Public License v2.0
54 stars 21 forks source link

fix forgot to change install_name for the linked library #96

Closed 3nids closed 3 years ago

3nids commented 3 years ago

fix QGIS.app/Contents/PlugIns/qgis/libdb2provider.so contains /opt/QGIS/qgis-deps-0.5.5/stage string <-- forgot to change install_name for the linked library?

see https://qgis.org/downloads/macos/nightly/qgis_nightly_master_20201102_122900.log

image

PeterPetrik commented 3 years ago

Yeah, this is more complicated since in QGIS 3.16 we do not link zstd, but with master we will link zstd, PDAL, las-perf, etc...

Maybe I suggest that we use the same branching mechanism as we do on QGIS? So the QGIS 3.16.x releases will used the "release_3_16" branch and the nightly will use "master" branch? @3nids how that sounds to you?

PeterPetrik commented 3 years ago

related to https://github.com/qgis/QGIS-Mac-Packager/pull/91

3nids commented 3 years ago

this is more complicated since in QGIS 3.16 we do not link zstd

and it would fail if not linked?

Maybe I suggest that we use the same branching mechanism as we do on QGIS? So the QGIS 3.16.x releases will used the "release_3_16" branch and the nightly will use "master" branch? @3nids how that sounds to you?

sounds like a plan.

PeterPetrik commented 3 years ago

I am not sure if it would fail in case the lib is missing in the linkage at all.

PeterPetrik commented 3 years ago

ok, in that case let me look at it later this week, since it is part of pointcloud stuff.

PeterPetrik commented 3 years ago

fixed in PDAL pr