search

qgis / QGIS-Resources

27 stars 38 forks source link

Update directory.csv #16

Closed northrivergeo closed 4 years ago

northrivergeo commented 6 years ago

Adding the NPS Symbols I created from https://www.nps.gov/hfc/carto/map-symbols.cfm

anitagraser commented 6 years ago

That looks like a huge collection. That's great!

Could you please add some preview images so users can see what they are downloading from within the Ressource Sharing plugin dialog?

Also an explicit license file (similar to what we have e.g. in https://github.com/qgis/QGIS-Resources/tree/master/collections/all_maki_icons) would be great.

Thank you!

northrivergeo commented 6 years ago

Will do! Give me just a bit and I will get that done. Yes - it was a bit of a pain to do but I hope worth it.

havatv commented 4 years ago

@rjhale1971 - this one has been around for a while. Any progress with the preview(s)?

havatv commented 4 years ago

@anitagraser, this collection seems to be worth including. Could it be merged before the preview is available? Or could someone else do the preview? I don't think it will be trivial for me, but someone who has done similar things before could perhaps fix it quite easily?

northrivergeo commented 4 years ago

Hey - good morning. I'm sorry - completely forgot about these icons into resource sharing. Let me take a look at it and get it working.

havatv commented 4 years ago

Hey - good morning. I'm sorry - completely forgot about these icons into resource sharing. Let me take a look at it and get it working.

Excellent!

northrivergeo commented 4 years ago

So I've added preview images - and pushed it all up. I'm not sure what to do next on this (since it's been so long).

havatv commented 4 years ago

@rjhale1971, I have just tested the repository. An impressive collection - thank you for sharing! There were some issues with the metadata.ini file. I have fixed them in a pull request against your repository (https://github.com/rjhale1971/NPS_Map_Symbols/pull/1). As soon as that pull request is merged, I think this is ready for inclusion. Then, we can ask @anitagraser to do the rest (merge).

havatv commented 4 years ago

@rjhale1971 has now merged https://github.com/rjhale1971/NPS_Map_Symbols/pull/1, and I was able to add the repository and install collections from it. So this PR should be ready for merging. What do you say, @anitagraser?

havatv commented 4 years ago

Thanks, @anitagraser! And thanks again for sharing, @rjhale1971!