qgis / QGIS-Resources

27 stars 38 forks source link

Update directory.csv #47

Closed jc-sdev closed 1 year ago

jc-sdev commented 1 year ago

Hello,

Will my request be processed? Thank you

akbargumbira commented 1 year ago

cc @ismailsunni if you can take a look and review the PR?

haubourg commented 1 year ago

Hi @jc-sdev , thanks for sharing your symbols. A small description of those symbols and why you want to add them in your PR and a basic "hello" would have been appreciated. We are all benevolent here, any help in reviewing changes are always appreciated.

ismailsunni commented 1 year ago

hi @jc-sdev first of all, thank you for your contribution. I started the review last week, but couldn't finish it. Here is the item that needs changes in the metadata.ini:

jc-sdev commented 1 year ago

cc @ismailsunni

I did the metadata modification and hope it will be good

Thanks

JC

jc-sdev commented 1 year ago

Hello haubourg

I'm sorry I didn't give you a little introduction and welcome but I've been struggling to update the directory. I'm still not comfortable enough with the way github works.

jc

ismailsunni commented 1 year ago

Hi @jc-sdev thanks for the update. There is one more issue, please use master as the default branch. Unfortunately, it's a known limitation.

jc-sdev commented 1 year ago

hi ismailsunni I think I've got it this time thanks jc

ismailsunni commented 1 year ago

Many thanks @jc-sdev :+1: