search

qgis / QGIS-Resources

27 stars 38 forks source link

create collection for styling z/m geometries #6

Closed haubourg closed 7 years ago

haubourg commented 7 years ago

that collection offers a first line style see https://www.youtube.com/watch?v=o_lAeKJhRkg

more to come for 2.5 d improvements.

elpaso commented 7 years ago

Thanks Règis! I did not test this PR yet but I have a few notes: you might want to provide more narrower preview images instead of a single one (that looks a bit too wide to me), the preview images will be presented in a nice ~ 4:3 slideshow to the users.

Also, you should add your collection metadata to: https://github.com/qgis/QGIS-Resources/blob/master/metadata.ini and add that to this PR.

haubourg commented 7 years ago

@elpaso. Hi alessandro, wow it seems I didn't save after cropping the preview. Should be fixed now

DelazJ commented 7 years ago

@elpaso (unless I miss it) maybe this repository needs a more verbose readme, mentioning where and what are the required files for a good contribution. Each of the previous PRs has a comment on a missing doc or a wrongly placed file. Or maybe a template for the PR (like https://github.com/qgis/QGIS/pull/3919)

elpaso commented 7 years ago

@DelazJ I totally agree.

We should add some links to the README.md and a PR template. The documentation about the metadata is here: http://www.akbargumbira.com/qgis_resources_sharing/author/creating-metadata.html

BTW, I think the resource sharing plugin will eventually be part of core and the docs will need to be included in the official QGIS manual (AFAIK they are already in RST format).

elpaso commented 7 years ago

@DelazJ I've just added a link to the manual: https://github.com/qgis/QGIS-Resources/blob/master/README.md

DelazJ commented 7 years ago

@elpaso Thanks for the reactivity

elpaso commented 7 years ago

@haubourg thanks!

anitagraser commented 7 years ago

Thanks, great work!

I think this collection would also benefit from adding a sample dataset like I did in my recently published collection https://github.com/anitagraser/QGIS-resource-collections/tree/master/collections/conveyor_belt_flows. This way, users can download the style and immediately test it with the provided test dataset.

haubourg commented 7 years ago

done in next PR!

2017-01-03 23:03 GMT+01:00 Anita Graser notifications@github.com:

@anitagraser commented on this pull request.

Thanks for sharing! As mentioned already, would be great to also have a sample dataset.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/qgis/QGIS-Resources/pull/6#pullrequestreview-15021706, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjendpLqNLLVAHdPFo4qFwqky_iTIfyks5rOsXMgaJpZM4LZh41 .