qgis / QGIS-Website

QGIS-Website
130 stars 285 forks source link

Missing translations #1116

Closed agiudiceandrea closed 1 year ago

agiudiceandrea commented 1 year ago

Description

The translation of some strings, which is available on Transifex since months, is missing on the Website.

For example, in the page https://qgis.org/it/site/forusers/download.html

image image image and probably other strings...

rduivenvoorde commented 1 year ago

Hi Andrea, should this be fixed by: https://github.com/qgis/QGIS-Website/issues/1111 ? As in: is this a github action now? Or should I manually update the strings ?

DelazJ commented 1 year ago

@rduivenvoorde From a quick glance, I can see action to push to transifex but I couldn't find instructions regarding pulling. Probably still a manual work for now...

agiudiceandrea commented 1 year ago

@DelazJ @rduivenvoorde, moreover, the translations are available on transifex since months. The translations were online last December https://web.archive.org/web/20221204060155/https://qgis.org/it/site/forusers/download.html

image

rduivenvoorde commented 1 year ago

Not sure what your message is?

Do you think it is an issue with pulling from transifex? As: the sources are uptodate, translated, but not pulled/build?

DelazJ commented 1 year ago

Afair, pulling from Transifex has always been a manual process so if nobody took this in charge in the last months, then it is normal the website is not up to date with translations

agiudiceandrea commented 1 year ago

@DelazJ there was something like a "regression": various strings already translated since months in transifex and already displayed translated on the website last December, "regressed" to the untranslated version.

rduivenvoorde commented 1 year ago

Afair, pulling from Transifex has always been a manual process so if nobody took this in charge in the last months, then it is normal the website is not up to date with translations

I do not think so? What I did manually was (often when there was some new release of bigger update of the website), is to create the list of resources, AND the new source file (the english one) and push that to transifex.

But the pulling from transifex was always part of the build scripts... (tx pull...)

But I think the pulling is now done by Sphinx itself? Or by some automagic action?

I will try to do the italian build now... and see if stuff is pulled...

rduivenvoorde commented 1 year ago

Ok, I see this:

Already up to date.                                                                                               
rm -rf source/static                                                                                              
# something in i18n/pot dir creates havoc when using gettext: remove it                  
rm -rf i18n/pot                                                                                                   
rm -rf i18n/*/LC_MESSAGES/docs/*/                                                                                 
rm -rf output/html/it/*                                                                                           
rm -f source/docs_conf.py*                                                                                        
rm -rf source/docs/*/                                                                                             
# all .mo files                                                                                                   
find i18n/*/LC_MESSAGES/ -type f -name '*.mo' -delete                                                             

Pulling it from transifex                                                                                         
tx ERROR: not enough values to unpack (expected 2, got 1)                       
make html                                                                                                         
make: [Makefile:149: full] Error 1 (ignored)                                                                      
make[1]: Entering directory '/site'                                                                                                                                                                                                  
rm -rf source/static                                                                                              

Removing all static content from source/static. 
agiudiceandrea commented 1 year ago

See also https://github.com/qgis/QGIS-Website/issues/1058.

DelazJ commented 1 year ago

@rduivenvoorde did you update tx to the new tool (https://github.com/transifex/cli)?

rduivenvoorde commented 1 year ago

@DelazJ @jef-n @why-not-try-calmer not sure what is going on here, but https://github.com/qgis/QGIS-Website/commit/5be4d374e226cbc651dbdbe18a56f285a551b626 added a tx binary(!) to the repo? and replaced our README with a copy from (I think) the tx cli repo?

@DelazJ IF we need a new tx tool we have to create a (docker) images so it is included in either the images, or we should make it available on the build server?

(I'm fairly lost in the build process now, sorry)

why-not-try-calmer commented 1 year ago

@DelazJ @jef-n @why-not-try-calmer not sure what is going on here, but 5be4d37 added a tx binary(!) to the repo? and replaced our README with a copy from (I think) the tx cli repo?

@DelazJ IF we need a new tx tool we have to create a (docker) images so it is included in either the images, or we should make it available on the build server?

(I'm fairly lost in the build process now, sorry)

Apparently my fork used the CI from upstream (this repository) to re-commit the wrong README. Thanks for raising this to my attention => #1117.

DelazJ commented 1 year ago

added a tx binary(!) to the repo?

Yes I noticed that while working on the docs repo update (forgot to ask whether it is desirable). We need the github action to take care of their removal also IMHO. Or maybe should we just go with https://github.com/transifex/cli-action? What do you think @why-not-try-calmer ?

@DelazJ IF we need a new tx tool

We DO need the new tool. I had scripts failing in docs too. The old transifex-client no longer works (officially for months but actually for 1 or 2 wweks). And the new tool is the one ued in this repo now, so we need to align our tools.

we have to create a (docker) images so it is included in either the images, or we should make it available on the build server?

I'm not versed in these considerations but I'd say better add it to the docker image?

DelazJ commented 1 year ago

Question: is it expected to not have 'en' in i18n folder? It used to be there (https://github.com/qgis/QGIS-Website/commits/master/i18n: present in 062251a3a84d9bdd53b72b9068e420b385ae66aa, removed in 9e1bf2fc0f45347a9eb0776197d8636a970473e2)

agiudiceandrea commented 1 year ago

The translations are missing in the latest build of the website (feb 24, 2023), too. The same translated texts are missing also in other languages, probably in all: image image

It seems currently a manual update is needed like last time https://github.com/qgis/QGIS-Website/issues/1058.

DelazJ commented 1 year ago

Seems manual pulling fixes the issue. Reopening so that it gets fixed on server side. Locally it required:

rduivenvoorde commented 1 year ago

Ok, I have updated/tested the docker images and pushed them to hub.docker.com

For what I see, now the website is building as it should

I did have to change stuff to make tx work with the local .transifexrc file.. so probably the doc sites also have to be updated...

rduivenvoorde commented 1 year ago

Mmm apperently those (looking at docs 3.22) do not use the tx cli to pull translations into the build. So probably all will be fine \o/

DelazJ commented 1 year ago

Thanks for the efforts @rduivenvoorde. Closing the report....

Mmm apperently those (looking at docs 3.22) do not use the tx cli to pull translations into the build. So probably all will be fine \o/

Indeed, docs translation follows another route and the repo on server is only the end point. Pulling is done directly by Transifex or from a local repo (until https://github.com/qgis/QGIS-Documentation/issues/7827 one day).

agiudiceandrea commented 1 year ago

For what I see, now the website is building as it should

Thanks, @rduivenvoorde and @DelazJ.